Ubuntu
fwts package

fwts: syntaxcheck should have a pedantic mode to also report ASL remarks

Bug #1200606 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Low
Colin Ian King

Bug Description

ASL now has some very useful "Remark" feedback, so we should think about getting this output also logged in the syntaxcheck test. I suggest a --syntaxcheck-pedantic option that turns this on, or maybe we should just enable it by default and make the warnings a low level failure.

Example remark:

DSDT.dsl 5811: Method (_BIF, 0, NotSerialized)
Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within)

..so this is useful since the _BIF control is tagged as NotSerialized yet it should be to stop potential race conditions.

This requires:

1. Working through all the ASL remarks and adding these to the .json database
2. Either adding the --syntaxcheck-pedantic flag, or enabling this by default.

See original description
Colin Ian King (colin-king)
Changed in fwts (Ubuntu):
importance: Undecided → Wishlist
assignee: nobody → Colin King (colin-king)
Colin Ian King (colin-king)
description: updated
Revision history for this message
Colin Ian King (colin-king) wrote :

Patch sent to fwts-devel mailing list https://lists.ubuntu.com/archives/fwts-devel/2013-September/003770.html

Changed in fwts (Ubuntu):
status: New → In Progress
importance: Wishlist → Low
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed, commit 9581aa0a9c93173ddf756e2589fb46767519b40d

Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.1 KiB)

This bug was fixed in the package fwts - 13.11.00-0ubuntu1

---------------
fwts (13.11.00-0ubuntu1) trusty; urgency=low

  [Alex Hung]
  * acpi: method: correct alphabetical order in comments to sync with acpi spec
  * acpi: method: add missing names to acpi-method list
  * acpi: method: add _CBA control method test (LP: #1249171)
  * acpi: method: add _CDM control method test (LP: #1249172)
  * acpi: method: add _CID control method test (LP: #1249174)
  * acpi: method: add _GAI control method test (LP: #1249894)
  * acpi: method: add _MSG control method test (LP: #1249939)
  * acpi: method: add _PMM control method test (LP: #1249941)
  * acpi: method: add _UPD and _UPP control method tests (LP: #1251168)

  [Colin Ian King]
  * lib: framework: report warning[s] correctly (LP:#1223736)
  * lib: update copyright year. (LP: #1226590)
  * acpi: mcfg: Parse /sys/bus/pci rather than using lspci (LP: #1226615)
  * syntaxcheck: report IASL compiler remarks as low failures (LP: #1200606)
  * acpi: fadt: sanity check reset register settings (LP: #1230394)
  * ACPICA: update to version 20130927.
  * iasl: capture output from stderr to catch iasl fatal errors
  * pci: aspm: remove the need to run and parse lspci output (LP: #1227853)
  * lib: fwts_klog: Add ability to write message to kernel log
  * acpi: s3: add timings report for suspend/resume (LP: #1241638)
  * acpi: s3: add --s3-suspend-time and --s3-resume-time (LP: #1241638)
  * lib: add new PCI definitions
  * pci: aspm: use new fwts PCI defintions
  * pci: maxreadreq: don't use lspci to get PCI specific data (LP: #1244676)
  * uefi: uefidump: add more checks to avoid buffer overruns (LP: #1239641)
  * bios: mtrr: don't use lspci to get PCI specific data (LP: #1244673)
  * wakealarm: use ioctl() interface as this more of a generic interface
    (LP: #1244184)
  * Tests: replace "check" with "test" in test name headings (LP: #1246650)
  * data: klog.json: Sync up with latest kernel 3.12 (LP: #1248499)
  * lib: Add PCI helper to return description of a device
  * lib: fwts_hwinfo: don't use external utils for H/W checks (LP: #1246646)
  * debian: control: remove some unrequired suggests
  * acpi: brightness: use /sys/class/backlight interface (LP: #1250517)
  * acpi: brightness: break up brightness test (LP: #1250429)
  * acpi: syntaxcheck: non-x86 may have ACPI support (LP: #1251293)
  * acpi: method: Change "Check" to "Test", (LP: #1246650)

  [Ivan Hu]
  * uefi: uefidump: fix the boot load option Boot#### larger than Boot1000
    doesn't be parsered (LP: #1225850)
  * uefi: uefidump: Add support for DriverOrder (LP: #1237263)
  * uefi: uefidump: add support for Driver#### (LP: #1237263)
  * uefidump: add support for Key#### (LP: #1237263)
  * uefi: uefidump: add support for db, dbx, dbt... variables scan
    (LP: #1247749)
  * uefi: uefidump: compare the SignarureType GUID and print out type for
    signature database parser (LP: #1247749)
  * uefi: uefidump: add support for KEK, KEKDefault, PK, PKDefault global
    variables scan (LP: #1247749)

  [Keng-Yu Lin]
  * Force to use automake1.11 to prevent FTBFS in Trusy (LP: #1250340)
 -- Keng-Yu Lin <email address hidden> Fri, 15 Nov 2013 14:11:0...

Read more...

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.