Firmware Test Suite

fwts: wakealarm test should work on non-x86 ACPI platforms

Bug #1244184 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
Medium
Colin Ian King
Firmware Test Suite 13.11.00

Bug Description

The FWTS wakealarm test aborts on ARM, since there the rtc device doesn't have a wakealarm file. However rtcwake works, so wakealarm should probably pass. This seems to be because rtcwake actually operates via ioctls on /dev/rtcX. One possibility though is that the absence of the wakealarm interface is actually a violation of ACPI standards and should be rectified in the kernel/driver. If this is shown to be the case then the wakealarm test should be updated to fail when it doesn't exist - or maybe another test should be created which tests the actual wakealarm function itself and keep this one to test for the presence of the interface.

Revision history for this message
Colin Ian King (colin-king) wrote :

can you attach the output from fwts when it fails

also, the strace of rtcwake on the ARM device

Thanks

Changed in fwts:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Colin King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

..and which ARM device are you testing on?

Revision history for this message
Colin Ian King (colin-king) wrote :

There are different ways to set the wakealarm, I'm going to rewrite this to use the ioctl() interface and get this tested to see if it works well on ACPI based x86 systems as well as ARM etc.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

results.log from fwts: http://paste.ubuntu.com/6295456/
rtcwake strace: http://paste.ubuntu.com/6295689/

Testing on Calxeda ECX-1000 (Highbank)

Revision history for this message
Colin Ian King (colin-king) wrote :

Brendan, I've uploaded a version of fwts in ppa:colin-king/white - it should be ready to test by Friday morning.

Colin Ian King (colin-king)
summary: - wakealarm test needs to be updated to pass when rtcwake would work
+ fwts: wakealarm test should work on non-x86 ACPI platforms
Revision history for this message
Colin Ian King (colin-king) wrote :

Brendan, I've uploaded a newer version of fwts in ppa:colin-king/white - the ARM version is now built and tested on the Claxeda box. I think this latest version will do the trick.

Revision history for this message
Colin Ian King (colin-king) wrote :

Tested on Calxeda box and also on a few x86 machines, we now have a more generic fix.

Patch sent to mailing list for approval and inclusion to next release of fwts: https://lists.ubuntu.com/archives/fwts-devel/2013-October/003885.html

Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed, commit 346a6f9db79561d0d61507254b5e1add7aaec52d

Changed in fwts:
status: In Progress → Fix Committed
Keng-Yu Lin (lexical)
Changed in fwts:
milestone: none → 13.11.00
Colin Ian King (colin-king)
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.