Nux

Unity makes unneeded copies of Nux DrawList

Bug #1167605 reported by Marco Trevisan (Treviño)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nux
Fix Released
Medium
Marco Trevisan (Treviño)
Nux 4.0.0
Unity
Fix Released
Medium
Marco Trevisan (Treviño)
Unity 7.1.0
nux (Ubuntu)
Fix Released
Undecided
Marco Trevisan (Treviño)
unity (Ubuntu)
Fix Released
Undecided
Marco Trevisan (Treviño)

Bug Description

Due to the fact that the list is retrieved in painting functions, it's better to reduce its cost to the maximum.

Related branches

lp:~3v1n0/nux/callgrind-improvements
PS Jenkins bot (community): Approve (continuous-integration)
Andrea Azzarone (community): Approve
Michi Henning (community): Approve
Diff: 67 lines (+12/-7)
4 files modified
Nux/WindowThread.cpp (+4/-5)
Nux/WindowThread.h (+1/-1)
configure.ac (+1/-1)
debian/changelog (+6/-0)
lp:~3v1n0/unity/callgrind-improvements
PS Jenkins bot (community): Approve (continuous-integration)
Andrea Azzarone (community): Approve
Brandon Schaefer (community): Approve
Diff: 785 lines (+168/-112)
15 files modified
dash/LensView.cpp (+9/-15)
dash/LensView.h (+1/-1)
debian/control (+1/-1)
launcher/Launcher.cpp (+5/-8)
launcher/SwitcherView.cpp (+10/-8)
panel/PanelController.cpp (+14/-24)
panel/PanelController.h (+1/-1)
panel/PanelTray.cpp (+1/-1)
plugins/unityshell/src/unityshell.cpp (+1/-5)
unity-shared/AbstractIconRenderer.h (+1/-6)
unity-shared/FileManager.h (+1/-0)
unity-shared/IconRenderer.cpp (+59/-27)
unity-shared/IconRenderer.h (+0/-1)
unity-shared/IconTextureSource.cpp (+48/-11)
unity-shared/IconTextureSource.h (+16/-3)
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
status: New → In Progress
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → Medium
milestone: none → 7.0.1
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:nux at revision None, scheduled for release in nux, milestone 4.0

Changed in nux:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: In Progress → Fix Committed
Marco Trevisan (Treviño) (3v1n0)
Changed in nux (Ubuntu):
status: New → Fix Committed
Changed in unity (Ubuntu):
status: New → Fix Committed
Changed in nux (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nux - 4.0.1daily13.04.15-0ubuntu1

---------------
nux (4.0.1daily13.04.15-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * Buming version to 4.0.1 as per recent ABI changes
  * Nux is doing a lot of unneeded nux::Geometry copies (LP: #1166268)
  * Unity makes unneeded copies of Nux DrawList (LP: #1167605)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 773
 -- Ubuntu daily release <email address hidden> Mon, 15 Apr 2013 04:14:18 +0000

Changed in nux (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.0.0daily13.04.15-0ubuntu1

---------------
unity (7.0.0daily13.04.15-0ubuntu1) raring; urgency=low

  [ Brandon Schaefer ]
  * Command lens does not close when pressing Alt+F2 (LP: #1167466)

  [ Andrea Azzarone ]
  * dash preview animation is slow on high resolution screens (also
    fullscreen mode) (LP: #1055126)

  [ Marco Trevisan (Treviño) ]
  * Unity makes unneeded copies of Nux DrawList (LP: #1167605)
  * Unityshell uses much of his CPU time only to get tray XIDs from
    PanelController (LP: #1167894)
  * Adding Lens results is more expensive than needed (LP: #1168569)
  * Opening new-window from quicklist static action does not focus the
    newly opened window (LP: #1164483)
  * Launcher pre-processes icons also when the icons have not been
    changed since last draw cycle (LP: #1168556)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3300
 -- Ubuntu daily release <email address hidden> Mon, 15 Apr 2013 04:17:42 +0000

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Nux Nux 4.0.0.

Changed in nux:
status: Fix Committed → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix released in Unity 7.1.0.

Changed in unity:
milestone: 7.0.1 → none
status: Fix Committed → Fix Released
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: none → 7.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.