Ubuntu UI Toolkit

The Empty list item conflicts with TextArea handling of enter key

Bug #1166840 reported by Ugo Riboni
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Critical
Zsombor Egri
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Unassigned

Bug Description

In the test code below, focus the TextArea and type Enter (or press Enter on the OSK on the phone).
It should insert a new line in the text, instead it produces this error:
file:///usr/lib/i386-linux-gnu/qt5/qml/Ubuntu/Components/AbstractButton.qml:41: Error: Insufficient arguments

The test case is below:

import QtQuick 2.0
import Ubuntu.Components 0.1
import Ubuntu.Components.ListItems 0.1 as ListItem

Item {
    height: 800
    width: 400

    ListItem.Empty {
        height: 200
        anchors.left: parent.left
        anchors.right: parent.right

        TextArea {
            anchors.fill: parent
        }
    }
}

See original description

Related branches

lp:~zsombi/ubuntu-ui-toolkit/textarea-in-listitem-empty
PS Jenkins bot: Approve (continuous-integration)
Tim Peeters: Needs Fixing
Diff: 130 lines (+81/-3)
3 files modified
demos/ListItems.qml (+9/-0)
modules/Ubuntu/Components/TextArea.qml (+17/-0)
tests/unit/tst_components/tst_textarea.qml (+55/-3)
lp:~timo-jyrinki/ubuntu-ui-toolkit/enable_daily_for_s
PS Jenkins bot: Approve (continuous-integration)
Didier Roche-Tolomelli (community): Approve
Ubuntu SDK team: Pending requested
Diff: 24 lines (+10/-2)
2 files modified
debian/bzr-builddeb.conf (+0/-2)
debian/changelog (+10/-0)
lp:~ken-vandine/ubuntu-ui-toolkit/raring.0.1.43
Timo Jyrinki: Approve
Diff: 552 lines (+312/-55)
9 files modified
debian/changelog (+14/-0)
demos/ListItems.qml (+9/-0)
modules/Ubuntu/Components/TextArea.qml (+17/-10)
modules/Ubuntu/Components/TextField.qml (+0/-10)
modules/Ubuntu/Components/plugin/quickutils.cpp (+28/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+5/-0)
tests/unit/tst_components/tst_textarea.qml (+125/-3)
tests/unit/tst_components/tst_textfield.qml (+90/-13)
themes/Ambiance/qmltheme/TextAreaDelegate.qml (+24/-19)
lp:ubuntu/raring/ubuntu-ui-toolkit
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
assignee: nobody → Tim Peeters (tpeeters)
importance: Undecided → High
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
importance: High → Critical
Revision history for this message
Tim Peeters (tpeeters) wrote :

I marked this as critical because
 < nerochiaro> zsombi: it's kind of blocking the merge in notepad of the slide-to-delete from the sdk

Olivier Tilloy (osomon)
description: updated
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
assignee: Tim Peeters (tpeeters) → Zsombor Egri (zsombi)
status: In Progress → Confirmed
Revision history for this message
Florian Boucault (fboucault) wrote :

The actual issue comes from the fact that TextArea does:

Keys.forwardTo: [controls]

Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision 421, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision 422, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Ken VanDine (ken-vandine)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.43

---------------
ubuntu-ui-toolkit (0.1.43) raring; urgency=low

  * Fix for text inputs staying disabled after being re-enabled. The previous
    workaround for removing input panel was blocking re-enabling a
    previously enabled input. (LP: #1164634)
  * Fixing disabled text input delegate background color theming when userValue
    is set to TextField or TextArea color property. (LP: #1169601)
  * Workaround for TextArea and TextField removing OSK when active focus is
    transferred from one instance to another using focus property (LP: #1163371)
  * Fix for TextArea Enter/Return keys being stolen when embedded in
    ListItems.Empty. (LP: #1166840)

ubuntu-ui-toolkit (0.1.42) raring; urgency=low

  [ Loïc Minier ]
  * Drop ubuntu-sdk package; now generated from sdk ubuntu-touch seed in
    ubuntu-touch-meta package.

  [ Timo Jyrinki ]
  * Sync with raring packaging, separate meta also in the PPA again
  * New upstream snapshot
    - Update documentation html styles
    - Fix the clamping of sheet width on narrow screens.
    - Added "make license" target
    - Added online and offline API documentation configurations, both with
      Ubuntu styling.

  [ Tim Peeters ]
  * Rewrite of theming engine. See CHANGES for details and deprecated APIs.

ubuntu-ui-toolkit (0.1.41) raring; urgency=low

  * Update documentation html styles
  * Automatic license checking for source files
  * Fix clamping bug for sheets on narrow screens

ubuntu-ui-toolkit (0.1.40) raring; urgency=low

  * Improve header and toolbar documentation for MainView/Page/PageStack/Tabs.
  * Fix bug in header (hide it when the header is empty)

ubuntu-ui-toolkit (0.1.39) quantal; urgency=low

  * New Icon component that displays icons from the icon theme.
  * Added libqt5svg5 as a dependency thus allowing use of SVGs in icon themes.
  * Fix bug in list items.
 -- Ken VanDine <email address hidden> Thu, 18 Apr 2013 10:18:52 -0400

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.