Ubuntu UI Toolkit

Re-enabling a TextField doesn't work

Bug #1164634 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Critical
Zsombor Egri
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Once a TextField is disabled, it cannot be re-enabled.

To reproduce:
1) Load up the Qml at the bottom of this report
2) Focus the TextField
3) Press Enter

What happens:
The field remains disabled

What should happen:
The field should stay enabled. Switch the TextField to a TextInput and it works correctly.

Code:

import QtQuick 2.0
import Ubuntu.Components 0.1

Rectangle {
    width: 200
    height: 40
    TextField {
        anchors.fill: parent.fill
        text: "Press Enter"
        onAccepted: {
            enabled = false;
            enabled = true;
        }
    }
}

Related branches

lp:~zsombi/ubuntu-ui-toolkit/textinputs-stay-disabled-when-reenabled
PS Jenkins bot: Approve (continuous-integration)
Florian Boucault: Pending requested
Diff: 335 lines (+106/-80)
6 files modified
modules/Ubuntu/Components/TextArea.qml (+0/-18)
modules/Ubuntu/Components/TextField.qml (+0/-18)
modules/Ubuntu/Components/plugin/quickutils.cpp (+28/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+5/-0)
tests/unit/tst_components/tst_textarea.qml (+21/-10)
tests/unit/tst_components/tst_textfield.qml (+52/-34)
lp:~ken-vandine/ubuntu-ui-toolkit/raring.0.1.43
Timo Jyrinki: Approve
Diff: 552 lines (+312/-55)
9 files modified
debian/changelog (+14/-0)
demos/ListItems.qml (+9/-0)
modules/Ubuntu/Components/TextArea.qml (+17/-10)
modules/Ubuntu/Components/TextField.qml (+0/-10)
modules/Ubuntu/Components/plugin/quickutils.cpp (+28/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+5/-0)
tests/unit/tst_components/tst_textarea.qml (+125/-3)
tests/unit/tst_components/tst_textfield.qml (+90/-13)
themes/Ambiance/qmltheme/TextAreaDelegate.qml (+24/-19)
lp:ubuntu/raring/ubuntu-ui-toolkit
lp:ubuntu/saucy-proposed/ubuntu-ui-toolkit
lp:ubuntu/saucy/ubuntu-ui-toolkit
Juhapekka Piiroinen (juhapekka-piiroinen)
Changed in ubuntu-ui-toolkit:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Zsombor Egri (zsombi)
Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
importance: High → Critical
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision 430, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Ken VanDine (ken-vandine)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.43

---------------
ubuntu-ui-toolkit (0.1.43) raring; urgency=low

  * Fix for text inputs staying disabled after being re-enabled. The previous
    workaround for removing input panel was blocking re-enabling a
    previously enabled input. (LP: #1164634)
  * Fixing disabled text input delegate background color theming when userValue
    is set to TextField or TextArea color property. (LP: #1169601)
  * Workaround for TextArea and TextField removing OSK when active focus is
    transferred from one instance to another using focus property (LP: #1163371)
  * Fix for TextArea Enter/Return keys being stolen when embedded in
    ListItems.Empty. (LP: #1166840)

ubuntu-ui-toolkit (0.1.42) raring; urgency=low

  [ Loïc Minier ]
  * Drop ubuntu-sdk package; now generated from sdk ubuntu-touch seed in
    ubuntu-touch-meta package.

  [ Timo Jyrinki ]
  * Sync with raring packaging, separate meta also in the PPA again
  * New upstream snapshot
    - Update documentation html styles
    - Fix the clamping of sheet width on narrow screens.
    - Added "make license" target
    - Added online and offline API documentation configurations, both with
      Ubuntu styling.

  [ Tim Peeters ]
  * Rewrite of theming engine. See CHANGES for details and deprecated APIs.

ubuntu-ui-toolkit (0.1.41) raring; urgency=low

  * Update documentation html styles
  * Automatic license checking for source files
  * Fix clamping bug for sheets on narrow screens

ubuntu-ui-toolkit (0.1.40) raring; urgency=low

  * Improve header and toolbar documentation for MainView/Page/PageStack/Tabs.
  * Fix bug in header (hide it when the header is empty)

ubuntu-ui-toolkit (0.1.39) quantal; urgency=low

  * New Icon component that displays icons from the icon theme.
  * Added libqt5svg5 as a dependency thus allowing use of SVGs in icon themes.
  * Fix bug in list items.
 -- Ken VanDine <email address hidden> Thu, 18 Apr 2013 10:18:52 -0400

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.