Ubuntu
ubuntuone-client package

Ubuntu One hook error, not python3 compatible

Bug #1098128 reported by Dimitri John Ledkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Packaging-dailies
Fix Released
Undecided
dobey
Stable-4-0
Triaged
Undecided
Unassigned
Stable-4-2
Fix Released
Undecided
dobey
Ubuntu One Client 4.1.91
Trunk
Fix Released
High
dobey
ubuntuone-client (Ubuntu)
Fix Released
High
Unassigned
Quantal
Won't Fix
Medium
Unassigned
Raring
Fix Released
High
Unassigned

Bug Description

apport hook is missing dependencies?
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apport/report.py", line 195, in _run_hook
    exec(compile(fd.read(), hook, 'exec'), symb)
  File "/usr/share/apport/package-hooks/source_ubuntuone-client.py", line 36, in <module>
    from dirspec.basedir import xdg_cache_home, xdg_config_home
ImportError: No module named 'dirspec'

noticed in bug 1098127

Related branches

lp:~xnox/ubuntuone-client/fix-apport
Rejected for merging into lp:ubuntuone-client
dobey (community): Disapprove
Ubuntu One hackers: Pending requested
Diff: 14 lines (+4/-0)
1 file modified
data/source_ubuntuone-client.py (+4/-0)
lp:~xnox/ubuntu/raring/ubuntuone-client/fix-apport
dobey (community): Disapprove
Ubuntu branches: Pending requested
Diff: 27 lines (+8/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
lp:~dobey/ubuntuone-client/apport-broke
Mike McCracken (community): Approve
Paul Hummer (community): Approve
Diff: 45 lines (+12/-13)
1 file modified
data/source_ubuntuone-client.py (+12/-13)
lp:~dobey/ubuntuone-client/py3-apport
Manuel de la Peña (community): Approve
Diff: 39 lines (+2/-3)
1 file modified
control (+2/-3)
lp:ubuntu/raring-proposed/ubuntuone-client
Revision history for this message
dobey (dobey) wrote :

This is actually a problem of apport running under python3 and loading hooks for apps that are using python2, and not having hooks in a separate directory for python3-using apps, since python3 breaks compatibility.

affects: ubuntuone-client (Ubuntu) → apport (Ubuntu)
Bryce Harrington (bryce)
summary: - hook error
+ ubuntuone-client hook error, not python3 compatible
Revision history for this message
Bryce Harrington (bryce) wrote : Re: ubuntuone-client hook error, not python3 compatible

The hook itself comes from the python-ubuntuone-client package, so I've added a bugtask for that. All apport hooks have to be moved to python3 now.

Leaving the apport bugtask open for now, for the request that python2 hooks still be allowed. However, I suspect this will be WONTFIX, since I understand the plan of record is to eventually move away from python2 entirely, so all hooks must be migrated.

Revision history for this message
Barry Warsaw (barry) wrote :

Just a note that LP: #1077089 is a requirement for ubuntuone-client port to Python 3. Please look at that bug's attached m-p.

Dimitri John Ledkov (xnox)
no longer affects: apport (Ubuntu)
Changed in ubuntuone-client (Ubuntu):
status: New → Confirmed
Changed in ubuntuone-client (Ubuntu Raring):
status: Confirmed → Triaged
Changed in ubuntuone-client (Ubuntu Quantal):
status: New → Triaged
importance: Undecided → Medium
Changed in ubuntuone-client (Ubuntu Raring):
importance: Undecided → High
Changed in ubuntuone-client (Ubuntu Quantal):
assignee: nobody → Dmitrijs Ledkovs (xnox)
Changed in ubuntuone-client (Ubuntu Raring):
assignee: nobody → Dmitrijs Ledkovs (xnox)
Changed in ubuntuone-client:
status: New → Confirmed
assignee: nobody → Dmitrijs Ledkovs (xnox)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The hook does not call any ubuntuone-client api.
I made the hook bi-lingual (both valid under python2 and python3)
This needs a python3-dirspec dependency to run the apport hook.
Please review linked branch merge proposals.

Revision history for this message
dobey (dobey) wrote :

Why was apport removed from this bug? Was another bug opened, or does one already exist, about apport outright breaking support for all the python2-using applications in the Ubuntu archive?

dobey (dobey)
summary: - ubuntuone-client hook error, not python3 compatible
+ Ubuntu One hook error, not python3 compatible
Julien Funk (jaboing)
tags: added: u1-by-dev u1-on-production u1-ubuntu
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 4.1.90-0ubuntu2

---------------
ubuntuone-client (4.1.90-0ubuntu2) raring; urgency=low

  * debian/control:
    - Remove gir1.2-indicate dependencies. (LP: #1112544)
    - Add indicator-sync to recommends. (LP: #1053482)
    - Add python3-dirspec to dependencies. (LP: #1098128)
  * debian/patches/00_apport_py3.patch:
    - Cherry pick patch from trunk to allow apport hook to work with
      Python 3 versions of apport. (LP: #1098128)
 -- Rodney Dawes <email address hidden> Fri, 01 Feb 2013 14:27:33 -0500

Changed in ubuntuone-client (Ubuntu Raring):
status: Triaged → Fix Released
Dimitri John Ledkov (xnox)
Changed in ubuntuone-client (Ubuntu Quantal):
assignee: Dmitrijs Ledkovs (xnox) → nobody
Changed in ubuntuone-client (Ubuntu Raring):
assignee: Dmitrijs Ledkovs (xnox) → nobody
Adolfo Jayme Barrientos (fitojb)
Changed in ubuntuone-client (Ubuntu Quantal):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.