Ubuntu

Merge lp:~xnox/ubuntu/raring/ubuntuone-client/fix-apport into lp:ubuntu/raring/ubuntuone-client

Proposed by Dimitri John Ledkov on 2013-01-31
Status: Rejected
Rejected by: Stéphane Graber on 2013-01-31
Proposed branch: lp:~xnox/ubuntu/raring/ubuntuone-client/fix-apport
Merge into: lp:ubuntu/raring/ubuntuone-client
Diff against target: 27 lines (+8/-1) 2 files modified
To merge this branch: bzr merge lp:~xnox/ubuntu/raring/ubuntuone-client/fix-apport
Reviewer Review Type Date Requested Status
Rodney Dawes (community) 2013-01-31 Disapprove on 2013-01-31
Ubuntu branches 2013-01-31 Pending
Review via email: mp+145758@code.launchpad.net

Commit Message

Add python3-dirspec dependency for apport hook. (LP: #1098128)

To post a comment you must log in.
Rodney Dawes (dobey) wrote :

I'm disapproving this because it doesn't fully fix the problem, as indicated by your other branch against upstream trunk, linked on the same bug.

We also don't use Vcs-Bzr UDD management for the package, so adding this change without fixing the other issues is basically useless to merge.

review: Disapprove
Dimitri John Ledkov (xnox) wrote :

Sure. I really could not find how/where ubuntuone-client packaging is handled. Plus the problem seems to be in the hook shipped by the upstream tarball and not under /debian/ package. But yeah, both changes should go together.

Unmerged revisions

123. By Dimitri John Ledkov on 2013-01-31

Add python3-dirspec dependency for apport hook. (LP: #1098128)

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-29 15:22:08 +0000
3+++ debian/changelog 2013-01-31 01:12:25 +0000
4@@ -1,3 +1,9 @@
5+ubuntuone-client (4.1.90-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Add python3-dirspec dependency for apport hook. (LP: #1098128)
8+
9+ -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Thu, 31 Jan 2013 00:29:59 +0000
10+
11 ubuntuone-client (4.1.90-0ubuntu1) raring; urgency=low
12
13 * New upstream release.
14
15=== modified file 'debian/control'
16--- debian/control 2013-01-29 15:22:08 +0000
17+++ debian/control 2013-01-31 01:12:25 +0000
18@@ -95,7 +95,8 @@
19 python-twisted-web,
20 python-pyinotify,
21 python-twisted-names,
22- python-oauth (>= 1.0~svn1092-0ubuntu2)
23+ python-oauth (>= 1.0~svn1092-0ubuntu2),
24+ python3-dirspec
25 Provides: ${python:Provides}
26 Replaces: ubuntuone-client (<< 0.92.0-0ubuntu1)
27 Recommends: zeitgeist-core

Subscribers

People subscribed via source and target branches