[MIR] hv-kvp-daemon-init

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1078106/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

Simple enough packaging, but I have a few questions/comments.

* You should run 'update-maintainer' in the source tree to set the Maintainer field to the standard value.
* The upstart task manually calls exec & kill instead of using an exec stanza. Is there a reason for that?
* There is a lintian warning that seems bad: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/hv-kvp-daemon-init. Is this a false positive from the automatically generated symlink? Debian shows no other package with that warning, so someone must have solved it.

I've cleaned all the lintian errors as of right now including the update-rc.d one and fixed the upstart behavior. I didn't catch the maintainer issue, but I'll get it fixed in bzr so it will be corrected on the next upload. I also need promotion in raring/quantal-proposed/precise-proposed

I'm not sure where mterry gets the idea that this bogus lintian warning is unique:

E: udev: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/udev-finish
E: udev: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/udev

It's just a by-product of the upstart-job symlink, yes, and we don't WANT to call update-rc.d for those, since we don't want rc?.d symlinks for them.

Proposed (untested) diff to actually use upstart exec correctly: http://paste.ubuntu.com/1440866/

Ok, so, the above diff doesn't work for a variety of reasons, but I have a more comprehensive diff here that does the right thing, but makes two (currently false) assumptions:

1) the lbm versions of the daemon are named after the flavour, rather than named $version_lbm (which conflicts between flavours)
2) we patch our version of the daemon to remove the daemon() call, so it can be managed effectively by upstart

I'm trying to talk to the kernel team into doing both these things, but if that can't happen in the window we need it to, we'll have to settle for something suboptimal.

Adding linux/LBM tasks to remove the daemon() call from the daemon, so it can actually be managed by upstart sanely.

This bug was fixed in the package hv-kvp-daemon-init - 0.3ubuntu4

---------------
hv-kvp-daemon-init (0.3ubuntu4) raring; urgency=low

  * Add build-dep on python and use dh_python2 to detect python deps.
 -- Adam Conrad <email address hidden> Mon, 17 Dec 2012 04:37:24 -0700

Fixes for the kernel components as requested by @Adam are now building in our PPA and will be ready for copying out shortly.

Moving back to incomplete, since this hasn't actually been approved yet (though it seems to have gotten promoted?). Will re-review.

I "got the idea" that the lintian warning was rare from Debian's lintian reports:
http://lintian.debian.org/tags/postrm-does-not-call-updaterc.d-for-init.d-script.html

Sure, hv-kvp-daemon-init is fine. Lintian warning still there, but as you say that is a false-positive from how upstart-job works. The upstart script now uses the exec directive, thanks!

Ya'll apparently have a bzr branch for this package? I'd like to see that mentioned in a Vcs-Bzr line in debian/control.

Approved, especially since this has a very limited scope. Setting to Fix Released, since this seems to have been pre-promoted.

Oh, I failed to mention I'd approved it along the way after fixing the upstart madness, Michael. Sorry about that. Just noticed the bug chatter when I came back to play.

Ah, thanks Adam.

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package linux-backports-modules-3.2.0 - 3.2.0-35.22

---------------
linux-backports-modules-3.2.0 (3.2.0-35.22) precise-proposed; urgency=low

  [ Andy Whitcroft ]

  * The hv_kvp_daemon is flavour specific when built from within LBM so
    include the flavour to avoid collisions in /usr/sbin.
    - LP: #1089970
  * Fix up the hv updater to handle cleanups in the master source (non-source
    change).
  * Update daemon to latest to obtain the following fixes:
   - hv_kvp_daemon -- prevent self-daemonising to allow upstart to track
   - LP: #1078106

linux-backports-modules-3.2.0 (3.2.0-35.21) precise-proposed; urgency=low

  [ Andy Whitcroft ]

  * Add a new HV backport module for use on the Hyper-V platform.
    - LP: #1089970

linux-backports-modules-3.2.0 (3.2.0-35.20) precise-proposed; urgency=low

  * Bump ABI for Precise 3.2.0-35.54
 -- Andy Whitcroft <email address hidden> Mon, 17 Dec 2012 10:00:43 +0000

This bug was fixed in the package hv-kvp-daemon-init - 0.3ubuntu4~12.04.0

---------------
hv-kvp-daemon-init (0.3ubuntu4~12.04.0) precise; urgency=low

  * Backport to precise to support new LBM hv_kvp_daemon (LP: #1089970)

hv-kvp-daemon-init (0.3ubuntu4) raring; urgency=low

  * Add build-dep on python and use dh_python2 to detect python deps.

hv-kvp-daemon-init (0.3ubuntu3) raring; urgency=low

  * Install our own copy of the hv_kvp_daemon wrapper that understands
    and prefers the linux-backports-module naming scheme (LP: #1089970)
  * Rewrite the upstart job to call the wrapper, now that the daemon
    no longer double-forks and can be managed by upstart (LP: #1078106)
  * Divert the linux-tools copy of the wrapper, and prefer our version

hv-kvp-daemon-init (0.3ubuntu2) raring; urgency=low

  * Added IP injection scripts to allow the KVP daemon to work with
    ubuntu. (LP: #1087488)

hv-kvp-daemon-init (0.3ubuntu1) raring; urgency=low

  * Fixed issue where kernel version detection was wrong (LP: #1089967).
  * Made upstart job aware of linux-backports-module provided
    kvp daemon (LP: #1089970, #1089973).

hv-kvp-daemon-init (0.2ubuntu1) raring; urgency=low

  * Added configuration to control whether or not the daemon runs.
 -- Adam Conrad <email address hidden> Mon, 17 Dec 2012 04:44:09 -0700

This bug was fixed in the package hv-kvp-daemon-init - 0.3ubuntu4~12.10.0

---------------
hv-kvp-daemon-init (0.3ubuntu4~12.10.0) quantal; urgency=low

  * Backport to quantal to support new LBM hv_kvp_daemon (LP: #1089970)

hv-kvp-daemon-init (0.3ubuntu4) raring; urgency=low

  * Add build-dep on python and use dh_python2 to detect python deps.

hv-kvp-daemon-init (0.3ubuntu3) raring; urgency=low

  * Install our own copy of the hv_kvp_daemon wrapper that understands
    and prefers the linux-backports-module naming scheme (LP: #1089970)
  * Rewrite the upstart job to call the wrapper, now that the daemon
    no longer double-forks and can be managed by upstart (LP: #1078106)
  * Divert the linux-tools copy of the wrapper, and prefer our version

hv-kvp-daemon-init (0.3ubuntu2) raring; urgency=low

  * Added IP injection scripts to allow the KVP daemon to work with
    ubuntu. (LP: #1087488)

hv-kvp-daemon-init (0.3ubuntu1) raring; urgency=low

  * Fixed issue where kernel version detection was wrong (LP: #1089967).
  * Made upstart job aware of linux-backports-module provided
    kvp daemon (LP: #1089970, #1089973).

hv-kvp-daemon-init (0.2ubuntu1) raring; urgency=low

  * Added configuration to control whether or not the daemon runs.
 -- Adam Conrad <email address hidden> Mon, 17 Dec 2012 04:44:09 -0700

This bug was fixed in the package linux-backports-modules-3.5.0 - 3.5.0-21.7

---------------
linux-backports-modules-3.5.0 (3.5.0-21.7) quantal-proposed; urgency=low

  [ Andy Whitcroft ]

  * The hv_kvp_daemon is flavour specific when built from within LBM so
    include the flavour to avoid collisions in /usr/sbin.
    - LP: #1089970
  * Fix up the hv updater to handle cleanups in the master source (non-source
    change).
  * Update daemon to latest to obtain the following fixes:
   - hv_kvp_daemon -- prevent self-daemonising to allow upstart to track
   - LP: #1078106

linux-backports-modules-3.5.0 (3.5.0-21.6) quantal-proposed; urgency=low

  [ Andy Whitcroft ]

  * Add a new HV backport module for use on the Hyper-V platform.
    - LP: #1089970

linux-backports-modules-3.5.0 (3.5.0-21.5) quantal-proposed; urgency=low

  * Bump ABI for Quantal 3.5.0-21.32

linux-backports-modules-3.5.0 (3.5.0-20.4) quantal-proposed; urgency=low

  * Bump ABI for Quantal 3.5.0-20.31
 -- Andy Whitcroft <email address hidden> Mon, 17 Dec 2012 12:11:04 +0000