Do not set GPIOs for speakers on IDT if there are no speakers
Bug #1040077 reported by
David Henningsson
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
David Henningsson |
Bug Description
This bug is used for tracking purposes only. Please do not triage.
Changed in linux (Ubuntu): | |
assignee: | nobody → David Henningsson (diwic) |
status: | New → In Progress |
tags: | added: blocks-hwcert-enablement |
To post a comment you must log in.
This fixes an issue with a machine where there were no speakers,
but GPIO0 had to be data=1 for the headphone to be functioning.
I'm not sure if we need a more advanced patch to solve all possible cases,
but if so, this patch would still provide a minor optimisation.
BugLink: https:/ /bugs.launchpad .net/bugs/ 1040077 pci/hda/ patch_sigmatel. c | 3 +++
Signed-off-by: David Henningsson <email address hidden>
---
sound/
1 file changed, 3 insertions(+)
The alsa-info for this machine can not be released yet, sorry.
diff --git a/sound/ pci/hda/ patch_sigmatel. c b/sound/ pci/hda/ patch_sigmatel. c pci/hda/ patch_sigmatel. c pci/hda/ patch_sigmatel. c line_out_ detect( struct hda_codec *codec,
index ea5775a..3edd73c 100644
--- a/sound/
+++ b/sound/
@@ -4543,6 +4543,9 @@ static void stac92xx_
struct auto_pin_cfg *cfg = &spec->autocfg;
int i;
+ if (cfg->speaker_outs == 0)
+ return;
+
for (i = 0; i < cfg->line_outs; i++) {
if (presence)
break;
--
1.7.9.5