Comment 2 for bug 1040077

Revision history for this message
Takashi Iwai (tiwai) wrote : Re: [PATCH] ALSA: hda - Do not set GPIOs for speakers on IDT if there are no speakers

At Wed, 22 Aug 2012 16:10:43 +0200,
David Henningsson wrote:
>
> This fixes an issue with a machine where there were no speakers,
> but GPIO0 had to be data=1 for the headphone to be functioning.
>
> I'm not sure if we need a more advanced patch to solve all possible cases,
> but if so, this patch would still provide a minor optimisation.
>
> BugLink: https://bugs.launchpad.net/bugs/1040077
> Signed-off-by: David Henningsson <email address hidden>

Thanks, applied now.

Takashi

> ---
> sound/pci/hda/patch_sigmatel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> The alsa-info for this machine can not be released yet, sorry.
>
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index ea5775a..3edd73c 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -4543,6 +4543,9 @@ static void stac92xx_line_out_detect(struct hda_codec *codec,
> struct auto_pin_cfg *cfg = &spec->autocfg;
> int i;
>
> + if (cfg->speaker_outs == 0)
> + return;
> +
> for (i = 0; i < cfg->line_outs; i++) {
> if (presence)
> break;
> --
> 1.7.9.5
>