video keeps playing when navigating away from the details page
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| software-center (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart | ||
| Precise |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
The video keeps playing when navigating away from the details page.
[TEST CASE]
1. Launch the current version of software-center in precise.
2. Open software-center and search for "Journey Down".
3. Select the item for "The Journey Down: Chapter One" and click the "More Info" button to view its details.
4. Find the video panel below the screenshots and click the start button to start it playing. Make sure the sound is up so that you can hear the pleasant sounds of the video.
5. Navigate back to the list view using the back navigation button at the top left of the Software Center window.
6. Note that even though you are viewing the list view now, you can still hear the sounds of the video playing in the background.
7. Click the forward navigation button to return to the details view and note that the video is still playing there.
8. Close Software Center.
9. Install the new version of software-center in -proposed.
10. Repeat steps 1 through 5 for the new version of Software Center.
11. Verify that now when you navigate away from the details view the sound of the video stops, and when you navigate back, verify that the video is no longer playing.
[REGRESSION POTENTIAL]
Risk is very low as the fix for this SRU simply stops the video playback upon leaving the details page. To check for regressions simply nagivate to and from the details page to check that the video reappears and plays/stops as expected. Note also that this fix includes a nice set of unit tests to verify the functionality overall.
---
1. run "software-center journeydown-one"
2. click on "play" in the video
3. click on "all software"
4. verify that the video keeps playing
What should happen:
4. the video should top or pause
Related branches
- Michael Vogt: Approve
-
Diff: 491 lines (+165/-59)8 files modifiedsoftwarecenter/ui/gtk3/session/navhistory.py (+2/-3)
softwarecenter/ui/gtk3/session/viewmanager.py (+5/-0)
softwarecenter/ui/gtk3/views/appdetailsview.py (+9/-8)
softwarecenter/ui/gtk3/widgets/videoplayer.py (+3/-0)
test/gtk3/test_appdetailsview.py (+58/-45)
test/gtk3/test_appmanager.py (+2/-1)
test/gtk3/test_viewmanager.py (+59/-0)
test/gtk3/test_widgets.py (+27/-2)
- Michael Vogt: Approve
-
Diff: 1150 lines (+292/-302)16 files modifiedsoftwarecenter/ui/gtk3/panes/availablepane.py (+97/-119)
softwarecenter/ui/gtk3/panes/basepane.py (+19/-12)
softwarecenter/ui/gtk3/panes/historypane.py (+6/-22)
softwarecenter/ui/gtk3/panes/installedpane.py (+9/-21)
softwarecenter/ui/gtk3/panes/pendingpane.py (+0/-17)
softwarecenter/ui/gtk3/panes/softwarepane.py (+26/-37)
softwarecenter/ui/gtk3/session/navhistory.py (+2/-4)
softwarecenter/ui/gtk3/session/viewmanager.py (+9/-26)
softwarecenter/ui/gtk3/views/appdetailsview.py (+1/-0)
softwarecenter/ui/gtk3/widgets/videoplayer.py (+3/-0)
tests/gtk3/test_appdetailsview.py (+36/-24)
tests/gtk3/test_availablepane.py (+36/-0)
tests/gtk3/test_navhistory.py (+14/-14)
tests/gtk3/test_panes.py (+4/-4)
tests/gtk3/test_widgets.py (+27/-0)
tests/gtk3/windows.py (+3/-2)
| Changed in software-center (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Natalia Bidart (nataliabidart) |
| Changed in software-center (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in software-center (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in software-center (Ubuntu Precise): | |
| status: | New → Fix Released |
| importance: | Undecided → Medium |
| Brian Murray (brian-murray) wrote Please test proposed package | #2 |
| tags: | added: verification-needed |
| description: | updated |
| Gary Lasker (gary-lasker) wrote | #3 |
| tags: |
added: verification-done removed: verification-needed |
| Changed in software-center (Ubuntu Precise): | |
| status: | Fix Released → Fix Committed |
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in software-center (Ubuntu Precise): | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package software-center - 5.3.1
---------------
software-center (5.3.1) quantal; urgency=low
[ Robert Roth ]
* lp:~evfool/software-center/lp752376:
- Updated the code to also work with file:// style deb filenames
(LP: LP #752376)
* lp:~evfool/software-center/lp1011605:
- update copyright date in the About window (LP: #1011605)
* lp:~evfool/software-center/lp1011567:
- add F1 key as accelerator for opening Help (LP: #1011567)
[ Gary Lasker ]
* debian/control:
- remove recommends for gir1.2-
longer needed (many thanks Robert Ancell)
[ Natalia Bidart ]
* lp:~nataliabidart/software-center/the-organizer:
+ Tests cleanup:
- Renamed test/ dir to tests/.
- Moved the testutils module to tests/utils.py.
- Removed all unnecessary logging setup per test file.
- Removed all unnecessary shebangs in test files.
- Isolated test code into tests/ directory, including moving all the
- Removed all the calls to Gtk.main() in gtk3 tests since that blocks the
execution of the suite.
- Pep8 and pyflakes fixes in the files already modified in this branch.
- Minor bug fix in the softwarecenter/
create a log dir with proper perms.
* lp:~nataliabidart/software-center/cant-stop-the-music.trunk:
- Stop the video if user navigates away from an app details page
(LP: #1003954).
- Refactored ViewManager so page displaying calls a leave_page before
changing a page, and a enter_page when navigating into a page.
[ Adam Conrad ]
* xz-lzma has been rolled into xz-utils, as of 5.1.1alpha+
[ Michael Vogt ]
* lp:~mvo/software-center/python-apt-0.8 :
- fix some leftover python-apt 0.7 API usage that will get removed
in quantal
* lp:~mvo/software-center/add-profile-cmdline
- add new --profile option to the app that writes out a cProfile
logfile
- add new dbus method com.ubuntu.
to write meliae memory dump for analyizing memleaks/cycles
* lp:~mvo/software-center/more-performance-measurement:
- add more fine grained data in --measure-
suppresses times <0.1s in the output
-- Michael Vogt <email address hidden> Thu, 21 Jun 2012 08:44:02 +0200