Merge lp:~xfactor973/apparmor-profiles/ceph-apparmor-profiles into lp:apparmor-profiles
Proposed by
Chris Holcombe
Status: | Merged |
---|---|
Merged at revision: | 165 |
Proposed branch: | lp:~xfactor973/apparmor-profiles/ceph-apparmor-profiles |
Merge into: | lp:apparmor-profiles |
Diff against target: |
67 lines (+58/-0) 2 files modified
ubuntu/14.04/usr.bin.ceph-mon (+28/-0) ubuntu/14.04/usr.bin.ceph-osd (+30/-0) |
To merge this branch: | bzr merge lp:~xfactor973/apparmor-profiles/ceph-apparmor-profiles |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Beattie | Approve | ||
Review via email: mp+289844@code.launchpad.net |
Description of the change
This patch includes apparmor profiles for the ceph-mon and ceph-osd processes. These were generated by running an extensive amulet test against the ceph-mon and ceph-osd juju charms. I can't say that they've exercised every possible code path but I think this is a good starting armor profile.
To post a comment you must log in.
Looks like a great start, thanks!
It'd be nice if the /proc/*/.. entries would use /proc/${pid}/.. or /proc/${pids}/.. -- while there's currently no difference between the two variables today, we do intend to modify ${pid} to refer to strictly "the current pid" via a kernel variable eventually.
/srv/ceph/ is probably a fair enough starting point to hardcode but if someone stores their OSDs elsewhere, it'd be nice if there was an #include <local/ usr.bin. ceph-osd> line near the bottom of the ceph-osd profile, so these sorts of modifications could be made easily. (See /etc/apparmor. d/usr.sbin. rsyslogd or /etc/apparmor. d/usr.sbin. ntpd for examples.)
Thanks