Merge lp:~vila/bzr/106898-put-bytes-raises-TypeError into lp:bzr
Status: | Merged |
---|---|
Approved by: | Vincent Ladeuil |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6613 |
Proposed branch: | lp:~vila/bzr/106898-put-bytes-raises-TypeError |
Merge into: | lp:bzr |
Diff against target: |
289 lines (+51/-73) 9 files modified
bzrlib/tests/per_transport.py (+2/-23) bzrlib/tests/test_smart_transport.py (+1/-1) bzrlib/transport/__init__.py (+14/-14) bzrlib/transport/local.py (+7/-5) bzrlib/transport/memory.py (+4/-10) bzrlib/transport/readonly.py (+1/-1) bzrlib/transport/remote.py (+11/-16) bzrlib/transport/sftp.py (+7/-3) doc/en/release-notes/bzr-2.7.txt (+4/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/106898-put-bytes-raises-TypeError |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Wilbur | Needs Fixing | ||
Review via email: mp+283522@code.launchpad.net |
Commit message
Make all transport put_bytes() raises TypeError when given unicode strings rather than bytes
Description of the change
While looking at https:/
These failures also occur on ubuntu wily and xenial.
From there I came across https:/
Looks like a valuable realignment of the code to be more consistent. This should also serve us well as we prepare to take on python 3 bytes.
I've suggested a few places where it looks like the parameter documentation could be updated to reflect the changes.
Other than that, +2.