Merge lp:~vikoadi/slingshot/async_update_menu into lp:~elementary-pantheon/slingshot/trunk
Proposed by
Viko Adi Rahmawan
Status: | Rejected |
---|---|
Rejected by: | Danielle Foré |
Proposed branch: | lp:~vikoadi/slingshot/async_update_menu |
Merge into: | lp:~elementary-pantheon/slingshot/trunk |
Diff against target: |
227 lines (+63/-42) 4 files modified
src/Backend/AppSystem.vala (+46/-18) src/Backend/SynapseSearch.vala (+12/-4) src/SlingshotView.vala (+5/-8) src/Widgets/CategoryView.vala (+0/-12) |
To merge this branch: | bzr merge lp:~vikoadi/slingshot/async_update_menu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Needs Fixing | ||
xapantu (community) | Approve | ||
Review via email: mp+268855@code.launchpad.net |
Description of the change
* asynchronousely update_app_system on AppSystem backend and Synapse plugin registration
To post a comment you must log in.
Unmerged revisions
- 584. By Viko Adi Rahmawan
-
tidy up
- 583. By Viko Adi Rahmawan
-
dont wait for refersh_popularty
- 582. By Viko Adi Rahmawan
-
dont wait for data-sink
- 581. By Viko Adi Rahmawan
-
merge trunk
- 580. By Viko Adi Rahmawan
-
dont use implisit begin
- 579. By Viko Adi Rahmawan
-
try to behave with zero apps
- 578. By Viko Adi Rahmawan
-
rename to async
- 577. By Viko Adi Rahmawan
-
use cancellation on appsystem update
- 576. By Viko Adi Rahmawan
-
dont screw to much code
- 575. By Viko Adi Rahmawan
-
dont create a new thread, update on each category addition
That's cool :)
However, as we discussed a few minutes ago, there is 2 main issues:
* Please add some Mutex, this way it is not thread safe, in AppSystem *and* in SynapseSearch.
* In the async function, if the thread creation fails, the function never finish, not sure it is a good thing, the yield should probably be before the catch.
(also some code style issues written in the diff comments)