Merge lp:~tsimonq2/ubiquity/lp-1763611 into lp:ubiquity

Proposed by Simon Quigley
Status: Merged
Merged at revision: 6616
Proposed branch: lp:~tsimonq2/ubiquity/lp-1763611
Merge into: lp:ubiquity
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
scripts/plugininstall.py (+1/-1)
To merge this branch: bzr merge lp:~tsimonq2/ubiquity/lp-1763611
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Ubuntu Installer Team Pending
Review via email: mp+343742@code.launchpad.net

Commit message

Detect the proper name for zram in /proc/swaps (LP: #1763611).

Description of the change

The correct scheme for zram mounts are /dev/zram#; detect this correctly (instead of the old naming scheme).

Without this, Lubuntu Bionic boot times (after install) are drastically increased.

I have tested this with today's daily, and it works as expected.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

The previous code is self-evidently wrong. Uploading the fix to the archive; installer team, please merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2018-04-19 11:06:23 +0000
+++ debian/changelog 2018-04-20 21:50:17 +0000
@@ -1,3 +1,9 @@
1ubiquity (18.04.9) bionic; urgency=medium
2
3 * Detect the proper name for zram in /proc/swaps (LP: #1763611).
4
5 -- Simon Quigley <tsimonq2@ubuntu.com> Fri, 20 Apr 2018 16:10:29 -0500
6
1ubiquity (18.04.8) bionic; urgency=medium7ubiquity (18.04.8) bionic; urgency=medium
28
3 * Automatic update of included source packages: console-setup9 * Automatic update of included source packages: console-setup
410
=== modified file 'scripts/plugininstall.py'
--- scripts/plugininstall.py 2018-02-26 13:30:27 +0000
+++ scripts/plugininstall.py 2018-04-20 21:50:17 +0000
@@ -769,7 +769,7 @@
769 continue769 continue
770 if not os.path.exists(words[0]):770 if not os.path.exists(words[0]):
771 continue771 continue
772 if words[0].startswith('/dev/ramzswap'):772 if words[0].startswith('/dev/zram'):
773 continue773 continue
774 size = int(words[2])774 size = int(words[2])
775 if size > biggest_size:775 if size > biggest_size:

Subscribers

People subscribed via source and target branches

to status/vote changes: