Merge lp:~statik/hydrazine/add-setup into lp:hydrazine
Proposed by
Elliot Murphy
Status: | Merged |
---|---|
Merged at revision: | 74 |
Proposed branch: | lp:~statik/hydrazine/add-setup |
Merge into: | lp:hydrazine |
Diff against target: |
68 lines (+44/-0) 4 files modified
.bzrignore (+2/-0) HACKING (+11/-0) TODO (+2/-0) setup.py (+29/-0) |
To merge this branch: | bzr merge lp:~statik/hydrazine/add-setup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pool | Approve | ||
Review via email: mp+29421@code.launchpad.net |
Description of the change
This adds a setup.py for generating source tarball releases to enable packaging for Ubuntu.
It also adds some notes about how to do releases to make it easy for weary release managers to DTRT.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Elliot Murphy wrote:
> Elliot Murphy has proposed merging lp:~statik/hydrazine/add-setup into lp:hydrazine.
>
> Requested reviews:
> hydrazine-core (hydrazine-core)
>
>
> This adds a setup.py for generating source tarball releases to enable packaging for Ubuntu.
> It also adds some notes about how to do releases to make it easy for weary release managers to DTRT.
>
Just a comment. I think it would be better to put __version__ into __init_ _.py and then update it from there. And in setup you
hydrazine/
can do:
import hydrazine hydrazine. __version_ _,
...
version=
That way you get the version in the python runtime as well, and they
stay in sync. Also note that a fairly common design is to use:
version_info = (0, 1, 0, 'dev', 0) # 5-tuple version using integers
__version__ = '.'.join(map(str, version_info))
bzr uses a slightly more complex tuple => string conversion, but the
tuple can be useful for not needing to parse a semi-arbitrary string.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
08lgACgkQJdeBCY SNAAMGXgCggdi3y WZWW9D1E4lyfai4 YUXf qjECkGEy35MlJcZ z3QyEFl+
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkw
kDIAoNHW+
=UAIu
-----END PGP SIGNATURE-----