Code review comment for lp:~statik/hydrazine/add-setup

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Elliot Murphy wrote:
> Elliot Murphy has proposed merging lp:~statik/hydrazine/add-setup into lp:hydrazine.
>
> Requested reviews:
> hydrazine-core (hydrazine-core)
>
>
> This adds a setup.py for generating source tarball releases to enable packaging for Ubuntu.
> It also adds some notes about how to do releases to make it easy for weary release managers to DTRT.
>

Just a comment. I think it would be better to put __version__ into
hydrazine/__init__.py and then update it from there. And in setup you
can do:

  import hydrazine
  ...
    version=hydrazine.__version__,

That way you get the version in the python runtime as well, and they
stay in sync. Also note that a fairly common design is to use:

 version_info = (0, 1, 0, 'dev', 0) # 5-tuple version using integers
 __version__ = '.'.join(map(str, version_info))

bzr uses a slightly more complex tuple => string conversion, but the
tuple can be useful for not needing to parse a semi-arbitrary string.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw08lgACgkQJdeBCYSNAAMGXgCggdi3yWZWW9D1E4lyfai4YUXf
kDIAoNHW+qjECkGEy35MlJcZz3QyEFl+
=UAIu
-----END PGP SIGNATURE-----