Merge ~smoser/cloud-init:fix/1778737-drop-integration-test into cloud-init:master

Proposed by Scott Moser
Status: Merged
Approved by: Scott Moser
Approved revision: 308ca86bb39719b05afd30462eaea93321a3dcc7
Merge reported by: Scott Moser
Merged at revision: 5858136215753cffc2080c85429a3c7a3754741c
Proposed branch: ~smoser/cloud-init:fix/1778737-drop-integration-test
Merge into: cloud-init:master
Diff against target: 99 lines (+0/-49)
1 file modified
dev/null (+0/-49)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Chad Smith Approve
Review via email: mp+348719@code.launchpad.net

Commit message

tests: drop salt-minion integration test

The salt minion integration test as we had it did not do a whole lot
more than the unit tests on that module did. Additionally, it caused
some transient failures at least in Ubuntu 18.04.

At a future date we may choose to add an integration test that installs
salt-minion and salt server and configures it to be a better test.

LP: #1778737

Description of the change

see commit message

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

LGTM!

review: Approve
Revision history for this message
Scott Moser (smoser) wrote :

I'll wait on c-i to post here
 https://jenkins.ubuntu.com/server/job/cloud-init-ci/132/
and then merge.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:308ca86bb39719b05afd30462eaea93321a3dcc7
https://jenkins.ubuntu.com/server/job/cloud-init-ci/132/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/132/rebuild

review: Approve (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

This merge has landed in commit 58581362 to cloud-init branch master.

To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=58581362

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/tests/cloud_tests/testcases/modules/salt_minion.py b/tests/cloud_tests/testcases/modules/salt_minion.py
0deleted file mode 1006440deleted file mode 100644
index fc9688e..0000000
--- a/tests/cloud_tests/testcases/modules/salt_minion.py
+++ /dev/null
@@ -1,38 +0,0 @@
1# This file is part of cloud-init. See LICENSE file for license information.
2
3"""cloud-init Integration Test Verify Script."""
4from tests.cloud_tests.testcases import base
5
6
7class Test(base.CloudTestCase):
8 """Test salt minion module."""
9
10 def test_minon_master(self):
11 """Test master value in config."""
12 out = self.get_data_file('minion')
13 self.assertIn('master: salt.mydomain.com', out)
14
15 def test_minion_pem(self):
16 """Test private key."""
17 out = self.get_data_file('minion.pem')
18 self.assertIn('------BEGIN PRIVATE KEY------', out)
19 self.assertIn('<key data>', out)
20 self.assertIn('------END PRIVATE KEY-------', out)
21
22 def test_minion_pub(self):
23 """Test public key."""
24 out = self.get_data_file('minion.pub')
25 self.assertIn('------BEGIN PUBLIC KEY-------', out)
26 self.assertIn('<key data>', out)
27 self.assertIn('------END PUBLIC KEY-------', out)
28
29 def test_grains(self):
30 """Test master value in config."""
31 out = self.get_data_file('grains')
32 self.assertIn('role: web', out)
33
34 def test_minion_installed(self):
35 """Test if the salt-minion package is installed"""
36 self.assertPackageInstalled('salt-minion')
37
38# vi: ts=4 expandtab
diff --git a/tests/cloud_tests/testcases/modules/salt_minion.yaml b/tests/cloud_tests/testcases/modules/salt_minion.yaml
39deleted file mode 1006440deleted file mode 100644
index 9227147..0000000
--- a/tests/cloud_tests/testcases/modules/salt_minion.yaml
+++ /dev/null
@@ -1,49 +0,0 @@
1#
2# Create config for a salt minion
3#
4# 2016-11-17: Currently takes >60 seconds results in test failure
5#
6enabled: True
7cloud_config: |
8 #cloud-config
9 salt_minion:
10 conf:
11 master: salt.mydomain.com
12 public_key: |
13 ------BEGIN PUBLIC KEY-------
14 <key data>
15 ------END PUBLIC KEY-------
16 private_key: |
17 ------BEGIN PRIVATE KEY------
18 <key data>
19 ------END PRIVATE KEY-------
20 grains:
21 role: web
22collect_scripts:
23 minion: |
24 #!/bin/bash
25 cat /etc/salt/minion
26 minion_id: |
27 #!/bin/bash
28 cat /etc/salt/minion_id
29 minion.pem: |
30 #!/bin/bash
31 PRIV_KEYFILE=/etc/salt/pki/minion/minion.pem
32 if [ ! -f $PRIV_KEYFILE ]; then
33 # Bionic and later automatically moves /etc/salt/pki/minion/*
34 PRIV_KEYFILE=/var/lib/salt/pki/minion/minion.pem
35 fi
36 cat $PRIV_KEYFILE
37 minion.pub: |
38 #!/bin/bash
39 PUB_KEYFILE=/etc/salt/pki/minion/minion.pub
40 if [ ! -f $PUB_KEYFILE ]; then
41 # Bionic and later automatically moves /etc/salt/pki/minion/*
42 PUB_KEYFILE=/var/lib/salt/pki/minion/minion.pub
43 fi
44 cat $PUB_KEYFILE
45 grains: |
46 #!/bin/bash
47 cat /etc/salt/grains
48
49# vi: ts=4 expandtab

Subscribers

People subscribed via source and target branches