Merge lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils
Proposed by
Sandy Carter (http://www.savoirfairelinux.com)
Status: | Needs review |
---|---|
Proposed branch: | lp:~savoirfairelinux-openerp/lp-community-utils/pep394 |
Merge into: | lp:lp-community-utils |
Diff against target: |
39 lines (+4/-4) 4 files modified
clone_mp_to_community.py (+1/-1) merge_mp.py (+1/-1) openerp-nag (+1/-1) replay_missing.py (+1/-1) |
To merge this branch: | bzr merge lp:~savoirfairelinux-openerp/lp-community-utils/pep394 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonardo Pistone | Approve | ||
Joël Grand-Guillaume @ camptocamp | Abstain | ||
Yannick Vaucher @ Camptocamp | Abstain | ||
Alexandre Fayolle - camptocamp | political opinion | Disapprove | |
Stefan Rijnhart (Opener) | Abstain | ||
Ronald Portier (Therp) (community) | code review and partial testing | Approve | |
Maxime Chambreuil (http://www.savoirfairelinux.com) | Approve | ||
Review via email: mp+204535@code.launchpad.net |
Description of the change
Adapted to crushbangs to PEP394 specifications.
The reason for this is added portability since not all distributions use python2 as the default python.
The biggest distro to use python3 as the target of the python symlink is Arch Linux.
`/usr/bin/env python` should only be used when code can be run in both python2 and python3
To post a comment you must log in.
Unmerged revisions
- 24. By Sandy Carter (http://www.savoirfairelinux.com)
-
[IMP] PEP 394 fix hashbangs
I doubt wether this change is really a good idea.
When running python from a virtualenv, in many cases this relies on a virtualenv specific python command to be the first in the path. When using python2, suddenly the whole virtualenv will be ignored and the script will revert to using the system python.
Therefore the change will break most virtualenv installations, which I think will be much more common than Arch Linux installs.
Or do I overlook something?