Merge lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into lp:lp-community-utils

Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 26
Merged at revision: 26
Proposed branch: lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env
Merge into: lp:lp-community-utils
Diff against target: 29 lines (+3/-3)
3 files modified
clone_mp_to_community.py (+1/-1)
merge_mp.py (+1/-1)
replay_missing.py (+1/-1)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp Approve
Ronald Portier (Therp) (community) code review Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+210217@code.launchpad.net

Description of the change

Adapted to hashbangs to PEP394 specifications, only env, not python2.

ref: https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394/+merge/204535

Using python2 in place of python has not yet been agreed on, but using env has mostly been embarrassed.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) :
review: Approve
Revision history for this message
Ronald Portier (Therp) (rportier1962) :
review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

I guess you meant embraced instead of embarrassed ? :)

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clone_mp_to_community.py'
2--- clone_mp_to_community.py 2013-09-22 14:36:16 +0000
3+++ clone_mp_to_community.py 2014-03-10 14:41:51 +0000
4@@ -1,4 +1,4 @@
5-#!/usr/bin/python
6+#!/usr/bin/env python
7 # -*- coding: utf-8 -*-
8 #
9 #
10
11=== modified file 'merge_mp.py'
12--- merge_mp.py 2013-09-22 14:36:16 +0000
13+++ merge_mp.py 2014-03-10 14:41:51 +0000
14@@ -1,4 +1,4 @@
15-#!/usr/bin/python
16+#!/usr/bin/env python
17 # -*- coding: utf-8 -*-
18 #
19 #
20
21=== modified file 'replay_missing.py'
22--- replay_missing.py 2013-09-22 14:36:16 +0000
23+++ replay_missing.py 2014-03-10 14:41:51 +0000
24@@ -1,4 +1,4 @@
25-#!/usr/bin/python
26+#!/usr/bin/env python
27 # -*- coding: utf-8 -*-
28 #
29 #

Subscribers

People subscribed via source and target branches