snappy-hwe-snaps

Merge ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:serial-vault-corrections into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~rmescandon/snappy-hwe-snaps/+git/engineering-tests
  3. serial-vault-corrections
  4. Merge into master
Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 943b774da2701a4980ad44cc8a7f0f5a9356bbae
Merged at revision: f7f5a4a461f9f7473138f2f5d5cd4af88bda2175
Proposed branch: ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:serial-vault-corrections
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 174 lines (+60/-66)
1 file modified
com.canonical.se:engineering-tests/units/serial-vault/serial-vault.pxu (+60/-66)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Konrad Zapałowicz (community) code Approve
Review via email: mp+330265@code.launchpad.net

Description of the change

- Renamed back serial-vault-server to serial-vault
- Padding adjustment
- Updated some not correct tests content
- Verified manually everything

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:62e542ab7b46a796d7d7a3ba7b4ea1fec55bafef
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1937/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3349
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1845/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3609
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2805/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1937/rebuild

review: Approve (continuous-integration)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

minor thing

review: Needs Fixing (code)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:943b774da2701a4980ad44cc8a7f0f5a9356bbae
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1938/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3350
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1846/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3610
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2806/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1938/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/com.canonical.se:engineering-tests/units/serial-vault/serial-vault.pxu b/com.canonical.se:engineering-tests/units/serial-vault/serial-vault.pxu
index ab1bea1..e01dfe5 100644
--- a/com.canonical.se:engineering-tests/units/serial-vault/serial-vault.pxu
+++ b/com.canonical.se:engineering-tests/units/serial-vault/serial-vault.pxu
@@ -13,14 +13,14 @@ category_id: serial_vault
13_description: Ensure that the serial-vault interface is auto-connected13_description: Ensure that the serial-vault interface is auto-connected
14plugin: manual14plugin: manual
15_steps:15_steps:
16 1. List the interfaces16 1. List the interfaces
17 .17 .
18 $ snap interfaces | serial-vault-server18 $ snap interfaces serial-vault
19 .19 .
20_verification:20_verification:
21 Verify that you see the following:21 Verify that you see the following:
22 :network serial-vault-server22 :network serial-vault
23 :network-bind serial-vault-server23 :network-bind serial-vault
2424
25id: serial_vault/setup/config25id: serial_vault/setup/config
26category_id: serial_vault26category_id: serial_vault
@@ -28,37 +28,35 @@ _description: Ensure that the serial-vault can access database
28plugin: manual28plugin: manual
29depends: serial_vault/setup/ensure_interface_connection_setup29depends: serial_vault/setup/ensure_interface_connection_setup
30_steps:30_steps:
31 1. Create settings.yaml with proper content ot access database31 1. Create settings.yaml with proper content to access database. For example:
32 .32 .
33 $ cat <<-EOF > settings.yaml33 title: "Serial Vault"
34 title: "Serial Vault"34 logo: "/static/images/logo-ubuntu-white.svg"
35 logo: "/static/images/logo-ubuntu-white.svg"35 mode: signing
36 mode: signing36 docRoot: "."
37 docRoot: "."37 driver: "postgres"
38 driver: "postgres"38 datasource: "dbname=serialvault sslmode=disable"
39 datasource: "dbname=serialvault sslmode=disable"39 keystore: "database"
40 keystore: "database"40 keystoreSecret: "secret code to encrypt the auth-key hash"
41 keystoreSecret: "secret code to encrypt the auth-key hash"41 csrfAuthKey: "2E6ZYnVYUfDLRLV/ne8M6v1jyB/376BL9ORnN3Kgb04uSFalr2ygReVsOt0PaGEIRuID10TePBje5xdjIOEjQQ=="
42 csrfAuthKey: "2E6ZYnVYUfDLRLV/ne8M6v1jyB/376BL9ORnN3Kgb04uSFalr2ygReVsOt0PaGEIRuID10TePBje5xdjIOEjQQ=="42 urlHost: "serial-vault"
43 urlHost: "serial-vault"43 urlScheme: http
44 urlScheme: http44 enableUserAuth: True
45 enableUserAuth: True45 .
46 EOF46 2. Apply config
47 .47 .
48 2. Apply config48 $ cat settings.yaml | sudo serial-vault.config
49 .49 .
50 $ cat settings.yaml | sudo serial-vault-server.config50 3. Restart service
51 .51 .
52 3. Restart service52 $ sudo systemctl restart snap.serial-vault.service.service
53 .53 .
54 $ sudo systemctl restart snap.serial-vault-server.serial-vault.service54 4. Check service status
55 .55 .
56 4. Check journal56 $ sudo systemctl status snap.serial-vault.service.service
57 .57 .
58 $ sudo journalctl
59 .
60_verification:58_verification:
61 Verify that you see in journal last page (Alt+G) that database has been created/updated and service is up and running, like this:59 Verify that you see that service is active (running) and that the database has been created/updated, like this:
62 Created the 'keypair' table.60 Created the 'keypair' table.
63 Created the 'model' table.61 Created the 'model' table.
64 Created the 'settings' table.62 Created the 'settings' table.
@@ -79,14 +77,14 @@ _description: Ensure that the serial vault admin commands can be run
79plugin: manual77plugin: manual
80depends: serial_vault/setup/config78depends: serial_vault/setup/config
81_steps:79_steps:
82 1. Try to run admin80 1. Try to run admin
83 .81 .
84 $ serial-vault-server.admin82 $ serial-vault.admin
85 .83 .
86 2. Try to run config84 2. Try to run config
87 .85 .
88 $ serial-vault-server.config86 $ serial-vault.config
89 .87 .
90_verification:88_verification:
91 Verify that each step ends showing up the help89 Verify that each step ends showing up the help
9290
@@ -96,14 +94,14 @@ _description: Ensure admin tool can add a superuser
96plugin: manual94plugin: manual
97depends: serial_vault/operation/ensure-commands-can-be-run95depends: serial_vault/operation/ensure-commands-can-be-run
98_steps:96_steps:
99 1. Add a user from console97 1. Add a user from console
100 .98 .
101 $ serial-vault-server.admin user add theuser -n TheName -r superuser -e theemail@email.com99 $ serial-vault.admin user add theuser -n TheName -r superuser -e theemail@email.com
102 .100 .
103 2. List users101 2. List users
104 .102 .
105 $ serial-vault-server.admin user list103 $ serial-vault.admin user list
106 .104 .
107_verification:105_verification:
108 Verify that just created user is in users list with superuser role106 Verify that just created user is in users list with superuser role
109107
@@ -113,16 +111,12 @@ _description: Ensure admin tool can fetch store cached account assertions
113plugin: manual111plugin: manual
114depends: serial_vault/operation/ensure-commands-can-be-run112depends: serial_vault/operation/ensure-commands-can-be-run
115_steps:113_steps:
116 1. Fetch cached accounts from the store114 1. Fetch cached accounts from the store
117 .115 .
118 $ serial-vault-server.admin account cache116 $ serial-vault.admin account cache
119 .117 .
120 2. List users
121 .
122 $ serial-vault-server.admin user list
123 .
124_verification:118_verification:
125 Verify that just created user is in users list with superuser role119 Verify that output shows account and keypair processing from Ubuntu store
126120
127id: serial_vault/operation/verify_api_is_reachable121id: serial_vault/operation/verify_api_is_reachable
128category_id: serial_vault122category_id: serial_vault
@@ -130,9 +124,9 @@ _description: Ensure signing service can be reached
130plugin: manual124plugin: manual
131depends: serial_vault/operation/ensure-commands-can-be-run125depends: serial_vault/operation/ensure-commands-can-be-run
132_steps:126_steps:
133 1. Request service version127 1. Request service version
134 .128 .
135 $ wget http://localhost:8080/v1/version129 $ wget http://localhost:8080/v1/version
136 .130 .
137_verification:131_verification:
138 Verify that the response content is {"version":"1.6.0"}132 Verify that the response content is {"version":"2.0-0"}

Subscribers

People subscribed via source and target branches