~rmescandon/snappy-hwe-snaps/+git/engineering-tests:serial-vault-corrections

Last commit made on 2017-09-06
Get this branch:
git clone -b serial-vault-corrections https://git.launchpad.net/~rmescandon/snappy-hwe-snaps/+git/engineering-tests
Only Roberto Mier Escandon can upload to this branch. If you are Roberto Mier Escandon please log in for upload directions.

Branch merges

Branch information

Name:
serial-vault-corrections
Repository:
lp:~rmescandon/snappy-hwe-snaps/+git/engineering-tests

Recent commits

943b774... by Roberto Mier Escandon

simplifying operation of checking connected interfaces

62e542a... by Roberto Mier Escandon

corrections of padding and some content in the tests after manually verifying

9d7d0c0... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch serial-vault-ones

Merge-Proposal: https://code.launchpad.net/~rmescandon/snappy-hwe-snaps/+git/engineering-tests/+merge/330071

Author: Roberto Mier Escandón  <email address hidden>

Serial vault plainbox tests

7c24479... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch nm-debug-config-test

Merge-Proposal: https://code.launchpad.net/~rmescandon/snappy-hwe-snaps/+git/engineering-tests/+merge/327102

Author: Roberto Mier Escandón  <email address hidden>

Plainbox tests for network manager debug enable/disable config option

ec12899... by Roberto Mier Escandon

added serial vault plainbox tests

a09e2d8... by Roberto Mier Escandon

Merge branch 'master' into nm-debug-config-test

fe7eda6... by Roberto Mier Escandon

fixed typo

85bcdb9... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch one-provider

Merge-Proposal: https://code.launchpad.net/~kissiel/snappy-hwe-snaps/+git/engineering-tests/+merge/328813

Author: Maciej Kisielewski <email address hidden>

Merge all the providers into one provider.

In order to empower reuse of the tests from engineering-tests, it's easier to have them in one plainbox-provider. They are all _provided_ by the same repository, so it IMHO makes more sense to have them grouped like that. Other (minor) benefit is having a lot less parts in snapcraft.yaml.

From a user's perspective nothing should change. I modified all the 'apps' to reflect the change in namespaces.

For your reviewing pleasure I baked a snap with what's on this branch:
https://drive.google.com/open?id=0B5xSCnq1-ZISdGtZLWpubkFwdDA

Potential follow up:
1) I left the alsa-utils reference untouched. The tests from A-U repo could live here, referencing, and requiring the A-U snap. This would deduplicate quite a bit.
2) All the 'apps' use plainbox run with a regex from commandline. I think having clearly defined "Test Plans" could be easier to use, maintain and - most importantly - reused.
3) Having a mix of dedicated 'launchers' (in ./bin) and direct calls could be improved, especially as a part of 2)
4) Theoretically plainbox should not be called. checkbox-cli should be used instead. This doesn't have any major importance here, as the benefits wouldn't be used (auto re-running of automated tests, bootstrapping test plans, ...)

b5df770... by Maciej Kisielewski

add a test plan with all eng. tests

Signed-off-by: Maciej Kisielewski <email address hidden>

c3e3e47... by Maciej Kisielewski

import alsa tests from alsa-utils snap

The alsa-utils repo contains plainbox jobs for testing alsa. Those jobs are
not characteristic to alsa-utils and are referenced from this snap, snap
that knows how to perform them. Also, to include them, this snap had to
have the whole alsa-utils part which is unnecessary.

This patch imports those three tests and drops alsa-utils part.
It also makes changes the 'launcher' (the tests are now in SE namespace).

Signed-off-by: Maciej Kisielewski <email address hidden>