Merge ~raharper/curtin:fix/no-by-id-grub-debconf into curtin:master
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Approved by: | Chad Smith |
Approved revision: | 56361669c20a0002b68390f2b2b8a11e1dd563ad |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~raharper/curtin:fix/no-by-id-grub-debconf |
Merge into: | curtin:master |
Diff against target: |
36 lines (+14/-0) 2 files modified
curtin/block/__init__.py (+2/-0) tests/unittests/test_block.py (+12/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chad Smith | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+389670@code.launchpad.net |
Commit message
block: disk_to_byid_path handle missing /dev/disk/by-id directory
If a system has disks without any persistent indentifier (like serial)
then udev won't create any /dev/disk/by-id symlinks. This can happen
in VMs which do not provide serial numbers by default (e.g. virtio).
If /dev/disk/by-id did not exist then os.listdir on that path would
raise a FileNotFoundExc
returning None (or the correct path).
This is fixed by checking if the target prefix exists and if not
return an empty dict.
LP: #1876258
To post a comment you must log in.
PASSED: Continuous integration, rev:56361669c20 a0002b68390f2b2 b8a11e1dd563ad /jenkins. ubuntu. com/server/ job/curtin- ci/175/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-amd64/ 175/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 175/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 175/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 175/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/175/ /rebuild
https:/