Merge ~raharper/curtin:fix/clear-holders-swap-partition into curtin:master
Proposed by
Ryan Harper
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Scott Moser | ||||
Approved revision: | a79452b863516727eeae12ff6e41b77044accbf5 | ||||
Merged at revision: | 358fca4b96f0c6cea300c6a65d4350166fc8ff48 | ||||
Proposed branch: | ~raharper/curtin:fix/clear-holders-swap-partition | ||||
Merge into: | curtin:master | ||||
Diff against target: |
213 lines (+127/-0) 6 files modified
curtin/block/clear_holders.py (+16/-0) curtin/swap.py (+15/-0) examples/tests/basic.yaml (+9/-0) examples/tests/dirty_disks_config.yaml (+26/-0) tests/unittests/test_clear_holders.py (+22/-0) tests/unittests/test_swap.py (+39/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott Moser (community) | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+336335@code.launchpad.net |
Description of the change
clear-holders: detect and remove devices from kernel swap as needed
During testing of subiquity the ephemeral environment may activate
existing swap partitions which then prevent curtin from using a device during
storage configuration. This branch introduces a change to TestBasic to add
a swap partition and a command to the dirty-disk mode to forcibly enable
the swap device to reproduce the error. The fix involves having
clear_holders detect and remove the device (disk or partition) from
the kernel swap via use of swapoff.
LP: #1743643
To post a comment you must log in.
PASSED: Continuous integration, rev:a67f0f460dc 92794a4986e0043 adb3256c9962a2 /jenkins. ubuntu. com/server/ job/curtin- ci/760/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-amd64/ 760 /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 760 /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 760 /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 760
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/760/ rebuild
https:/