Merge ~mgerdts/cloud-init:update_metadata into cloud-init:master
Status: | Rejected |
---|---|
Rejected by: | Scott Moser |
Proposed branch: | ~mgerdts/cloud-init:update_metadata |
Merge into: | cloud-init:master |
Diff against target: |
57 lines (+9/-6) 2 files modified
cloudinit/sources/__init__.py (+7/-5) cloudinit/sources/tests/test_init.py (+2/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Needs Fixing | |
Scott Moser | Approve | ||
Review via email: mp+350374@code.launchpad.net |
Commit message
update_metadata re-config on every boot comments and tests not quite right
The comment in update_metadata() that explains how a datasource should
enable network reconfig on every boot presumes that
EventType.
the case, and as such a datasource that needs to configure networking
when it is a new instance and every boot needs to include both event
types.
To make the situation above easier to debug, update_metadata() now
logs when it returns false.
To make it so that datasources do not need to test before appending to
the update_
test_update_
to allow datasources to support EventType.BOOT.
that looks good. thanks.