Merge lp:~mahfiaz/openlp/opensong-bible-importer-crash into lp:openlp
Proposed by
mahfiaz
Status: | Rejected |
---|---|
Rejected by: | Andreas Preikschat |
Proposed branch: | lp:~mahfiaz/openlp/opensong-bible-importer-crash |
Merge into: | lp:openlp |
Diff against target: |
51 lines (+9/-3) 3 files modified
openlp/plugins/bibles/forms/bibleupgradeform.py (+1/-1) openlp/plugins/bibles/lib/db.py (+1/-1) openlp/plugins/bibles/lib/opensong.py (+7/-1) |
To merge this branch: | bzr merge lp:~mahfiaz/openlp/opensong-bible-importer-crash |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Preikschat (community) | Needs Resubmitting | ||
Tim Bentley | Needs Fixing | ||
Review via email: mp+183328@code.launchpad.net |
This proposal supersedes a proposal from 2013-08-24.
Description of the change
Fixes traceback when using opensong importer, not working cancel button for any of bible importers and opensong importer not acception XML file which starts with a space.
To post a comment you must log in.
Lines 34 and 41 are not needed.
You need to add a test even if it is not connected to the change. Welcome to the 2.2 world!