Merge lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ into lp:prestashoperpconnect

[Maxime Jacquet]

Hi,

For mapping categories in ~prestashoperpconnect-core-editors/prestashoperpconnect/7.0 : /prestashoperpconnect_catalog_manager/product.py (revision 272), line 216, there is an incorrect mapping dictionnary in the 'association' mapping function

'categories': {'category_id': self._get_product_category(record)}

replaced by

'categories': {'category': self._get_product_category(record)}

Regards,

Maxime

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

The project has moved to Github https://github.com/OCA/connector-prestashop.
Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.

I put this MP in rejected in the meanwhile.

Regards

review: Disapprove

[Diego (diegogalmarini)]

Hi Sebastien, I recibe lot of mails from you, are the final versión OK....
I was testing in http://matesabio.com.ar/ and It was working...

Regards

*Diego Galmarini*
On-line Marketing | Design Dpt.
<email address hidden>
Tel: [phone]
LinkedIn: diegogalmarini <http://www.linkedin.com/in/diegogalmarini>
skype: diegogalmarini
twitter: @diegogalmarini <http://twitter.com/#!/diegogalmarini>
YouTube: HostelsReviews <http://www.youtube.com/user/HostelsReviews>
facebook: diegogalmarini <https://www.facebook.com/diego.galmarini>

View or join the call: https://www.uberconference.com/diegogalmarini
Dial in number: [phone]
PIN: 54017

Aviso Legal
Este mensaje y sus anexos pueden contener información confidencial, por lo
que se informa de que su uso no autorizado está prohibido por la ley. Si
Vd. considera que no es el destinatario pretendido por el remitente, por
favor póngalo en su conocimiento por esta misma vía o por cualquier otro
medio y elimine esta comunicación y los anexos de su sistema, sin copiar,
remitir o revelar los contenidos del mismo a cualquier otra persona.
Cualquier información, opinión, conclusión, recomendación, etc. contenida
en el presente mensaje no relacionada con la actividad empresarial de Diego
Galmarini, y/o emitida por persona sin capacidad para ello, deberá
considerarse como no roporcionada ni aprobada por nuestra Entidad. Diego
Galmarini pone los medios a su alcance para garantizar la seguridad y
ausencia de errores en la correspondencia electrónica, pero no puede
asegurar la inexistencia de virus o la no alteración de los documentos
transmitidos electrónicamente, por lo que declina cualquier responsabilidad
a este respecto.

Disclaimer
This message and its contents may contain confidential information and its
non-authorised use is prohibited by law. If you are not the intended
recipient of this email, please advise the sender of the fact using the
same, or other, means and delete this message and its contents from your
system without copying, forwarding or revealing the contents of the message
to any other person. Any information, opinion, conclusion, recommendation,
etc. contained in this message and which is unrelated to the business
activity of Diego Galmarini and/or issued by unauthorised personnel, shall
be considered unapproved by the Organizatión. Prodasva, S.L.. implements
control measures to ensure, as far as possible, the security and
reliability of all its electronic correspondence. However, the Diego
Galmarini does not guarantee that emails are virus-free or that documents
have not be altered and takes no responsibility in this respect.

Diego Galmarini

2014-10-07 4:47 GMT-03:00 Sébastien BEAU - http://www.akretion.com <
<email address hidden>>:

> The proposal to merge
> lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ
> into lp:prestashoperpconnect has been updated.
>
> Status: Needs review => Rejected
>
> For more details, see:
>
> https://code.launchpad.net/~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ/+merge/192517
> --
>
> https://code.launchpad.net/~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-ma...

Unmerged revisions

272. By OPENova on 2013-10-24

Fix categories mapping function

=== modified file 'prestashoperpconnect_catalog_manager/product.py'
--- prestashoperpconnect_catalog_manager/product.py	2013-09-06 09:09:20 +0000
+++ prestashoperpconnect_catalog_manager/product.py	2013-10-24 14:31:11 +0000
@@ -213,7 +213,7 @@
     def associations(self, record):
         return {
             'associations':{
-                'categories': {'category_id': self._get_product_category(record)},
+                'categories': {'category': self._get_product_category(record)},
                 'product_features': {'product_feature': self._get_product_feature(record)},
                 }
             }