Merge lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ into lp:prestashoperpconnect

Proposed by Maxime Jacquet on 2013-10-24
Status: Rejected
Rejected by: Sébastien BEAU - http://www.akretion.com on 2014-10-07
Proposed branch: lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ
Merge into: lp:prestashoperpconnect
Diff against target: 12 lines (+1/-1)
1 file modified
prestashoperpconnect_catalog_manager/product.py (+1/-1)
To merge this branch: bzr merge lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ
Reviewer Review Type Date Requested Status
Sébastien BEAU - http://www.akretion.com 2013-10-24 Disapprove on 2014-10-07
Review via email: mp+192517@code.launchpad.net

Description of the change

Hi,

For mapping categories in ~prestashoperpconnect-core-editors/prestashoperpconnect/7.0 : /prestashoperpconnect_catalog_manager/product.py (revision 272), line 216, there is an incorrect mapping dictionnary in the 'association' mapping function

'categories': {'category_id': self._get_product_category(record)}

replaced by

'categories': {'category': self._get_product_category(record)}

Regards,

Maxime

To post a comment you must log in.

The project has moved to Github https://github.com/OCA/connector-prestashop.
Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.

I put this MP in rejected in the meanwhile.

Regards

review: Disapprove
Diego (diegogalmarini) wrote :
Download full text (3.2 KiB)

Hi Sebastien, I recibe lot of mails from you, are the final versión OK....
I was testing in http://matesabio.com.ar/ and It was working...

Regards

*Diego Galmarini*
On-line Marketing | Design Dpt.
<email address hidden>
Tel: +54 291 4124 369
LinkedIn: diegogalmarini <http://www.linkedin.com/in/diegogalmarini>
skype: diegogalmarini
twitter: @diegogalmarini <http://twitter.com/#!/diegogalmarini>
YouTube: HostelsReviews <http://www.youtube.com/user/HostelsReviews>
facebook: diegogalmarini <https://www.facebook.com/diego.galmarini>

View or join the call: https://www.uberconference.com/diegogalmarini
Dial in number: (716) 748-0508
PIN: 54017

Aviso Legal
Este mensaje y sus anexos pueden contener información confidencial, por lo
que se informa de que su uso no autorizado está prohibido por la ley. Si
Vd. considera que no es el destinatario pretendido por el remitente, por
favor póngalo en su conocimiento por esta misma vía o por cualquier otro
medio y elimine esta comunicación y los anexos de su sistema, sin copiar,
remitir o revelar los contenidos del mismo a cualquier otra persona.
Cualquier información, opinión, conclusión, recomendación, etc. contenida
en el presente mensaje no relacionada con la actividad empresarial de Diego
Galmarini, y/o emitida por persona sin capacidad para ello, deberá
considerarse como no roporcionada ni aprobada por nuestra Entidad. Diego
Galmarini pone los medios a su alcance para garantizar la seguridad y
ausencia de errores en la correspondencia electrónica, pero no puede
asegurar la inexistencia de virus o la no alteración de los documentos
transmitidos electrónicamente, por lo que declina cualquier responsabilidad
a este respecto.

Disclaimer
This message and its contents may contain confidential information and its
non-authorised use is prohibited by law. If you are not the intended
recipient of this email, please advise the sender of the fact using the
same, or other, means and delete this message and its contents from your
system without copying, forwarding or revealing the contents of the message
to any other person. Any information, opinion, conclusion, recommendation,
etc. contained in this message and which is unrelated to the business
activity of Diego Galmarini and/or issued by unauthorised personnel, shall
be considered unapproved by the Organizatión. Prodasva, S.L.. implements
control measures to ensure, as far as possible, the security and
reliability of all its electronic correspondence. However, the Diego
Galmarini does not guarantee that emails are virus-free or that documents
have not be altered and takes no responsibility in this respect.

Diego Galmarini

2014-10-07 4:47 GMT-03:00 Sébastien BEAU - http://www.akretion.com <
<email address hidden>>:

> The proposal to merge
> lp:~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ
> into lp:prestashoperpconnect has been updated.
>
> Status: Needs review => Rejected
>
> For more details, see:
>
> https://code.launchpad.net/~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-mapping_categories_MJ/+merge/192517
> --
>
> https://code.launchpad.net/~m-jacquet/prestashoperpconnect/prestashoperpconnect-fix-ma...

Read more...

Unmerged revisions

272. By OPENova on 2013-10-24

Fix categories mapping function

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'prestashoperpconnect_catalog_manager/product.py'
2--- prestashoperpconnect_catalog_manager/product.py 2013-09-06 09:09:20 +0000
3+++ prestashoperpconnect_catalog_manager/product.py 2013-10-24 14:31:11 +0000
4@@ -213,7 +213,7 @@
5 def associations(self, record):
6 return {
7 'associations':{
8- 'categories': {'category_id': self._get_product_category(record)},
9+ 'categories': {'category': self._get_product_category(record)},
10 'product_features': {'product_feature': self._get_product_feature(record)},
11 }
12 }