Merge charm-grafana:dashboards_joined into charm-grafana:master
Proposed by
Joe Guo
Status: | Merged |
---|---|
Approved by: | Joe Guo |
Approved revision: | 6ab6bed6082347fbc5f92fa703b3118f21da60a0 |
Merged at revision: | c632b1fde22240963c81f338208d4d226638045a |
Proposed branch: | charm-grafana:dashboards_joined |
Merge into: | charm-grafana:master |
Diff against target: |
36 lines (+25/-0) 1 file modified
src/reactive/grafana.py (+25/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Hebden (community) | Approve | ||
Xav Paice (community) | Approve | ||
Review via email: mp+391854@code.launchpad.net |
Commit message
add dashboards-joined hook
when relate an operator based charm, e.g.: cloudstats, to grafana, this hook won't trigger:
@when(
@when_
def import_
...
So dashboard will not be imported and there is no error.
Add a normal `joined` hook, query relation data directly with key, so operator based
charm can relate to grafana and import dashboard.
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.