Merge lp:~kdub/powerd/fix-1258655 into lp:powerd
Status: | Rejected |
---|---|
Rejected by: | Kevin DuBois |
Proposed branch: | lp:~kdub/powerd/fix-1258655 |
Merge into: | lp:powerd |
Diff against target: |
227 lines (+72/-47) 1 file modified
src/display.c (+72/-47) |
To merge this branch: | bzr merge lp:~kdub/powerd/fix-1258655 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Seth Forshee (community) | Disapprove | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+199582@code.launchpad.net |
Commit message
1) eliminating fb_state as a global variable and locking actual_
2) for earlysuspend devices, the responsibility for changing state and turning on the display/compositor via dbus is in the thread-monitoring state. for non-earlysuspend devices, that responsibility remains in the same thread that it is in now.
fixes ( LP: #1258655 )
Description of the change
powerd must ensure that the system is in a usable state before triggering the calls to the display server.
The problem was that for earlysuspend devices, there were two threads that thought they had responsibility for turning the display on, when really only the thread monitoring the files in /sys/power had the right to do so. Furthermore, the variables concerned with display state "actual_
This MP fixes these issues by:
1) eliminating fb_state as a global variable and locking actual_
2) for earlysuspend devices, the responsibility for changing state and turning on the display/compositor via dbus is in the thread-monitoring state. for non-earlysuspend devices, that responsibility remains in the same thread that it is in now.
fixes ( LP: #1258655 )
Also, please feel free to test by jamming on the power button repeatedly and quickly. I have manually tested on my nexus 4 (an early suspend device) and my nexus 10 (a non-early suspend device).
Unmerged revisions
- 108. By Kevin DuBois
-
merge base
- 107. By Kevin DuBois
-
further cleanup, make sure non-early suspend devices still work
- 106. By Kevin DuBois
-
bit of cleanup in fb thread
- 105. By Kevin DuBois
-
change state handling to make more robust display interaction
- 104. By Kevin DuBois
-
add some locking to the variables accessed in both therads
PASSED: Continuous integration, rev:108 jenkins. qa.ubuntu. com/job/ powerd- ci/132/ jenkins. qa.ubuntu. com/job/ powerd- trusty- armhf-ci/ 2 jenkins. qa.ubuntu. com/job/ powerd- trusty- armhf-ci/ 2/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/powerd- ci/132/ rebuild
http://