Code review comment for lp:~kdub/powerd/fix-1258655

I've been going back over the code, and as long as the dbus calls are handled on the main thread (which was my understanding, but I'm no expert about dbus) then all display on/off code should happen on the main thread. As far as I can tell there are adequate protections to prevent turning on the display when earlysuspend is enabled. I really don't think there are any problems there. In particular the display code holds an active request when unity's setScreenPowerMode() is called, and it's called on the main loop, so there should be absolutely no way that earlysuspend is active when it is called and there should be absolutely no way for earlysuspend to become active until the dbus call returns (and setScreenPowerMode() *is* called synchronously).

I did just remember though bug #1208433, which may be related. I think rsalveti and I chatted about that one once and we both thought that the root cause was probably something in the display driver. maguro and grouper are both earlysuspend devices and neither have the same problem with rapidly pressing the power key. Are you able to try either of those with unity to verify that's still the case?