Merge lp:~justin-fathomdb/nova/libvirt-getversion-whackamole into lp:~hudson-openstack/nova/trunk
Proposed by
justinsb
Status: | Merged |
---|---|
Approved by: | Josh Kearney |
Approved revision: | 854 |
Merged at revision: | 867 |
Proposed branch: | lp:~justin-fathomdb/nova/libvirt-getversion-whackamole |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
23 lines (+12/-1) 1 file modified
nova/virt/libvirt_conn.py (+12/-1) |
To merge this branch: | bzr merge lp:~justin-fathomdb/nova/libvirt-getversion-whackamole |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jesse Andrews (community) | Approve | ||
Josh Kearney (community) | Approve | ||
Jay Pipes (community) | Approve | ||
Vish Ishaya | Pending | ||
Soren Hansen | Pending | ||
Review via email: mp+54475@code.launchpad.net |
Commit message
Detect if user is running the default Lucid version of libvirt, and give a nicer error message
Description of the change
Check both libvirt connection object (Maverick) and libvirt namespace (Lucid) for getVersion function
Earlier versions of the python libvirt binding had getVersion in the libvirt namespace, not on the connection object. Check both.
To post a comment you must log in.
lgtm.