Merge lp:~justin-fathomdb/nova/libvirt-getversion-whackamole into lp:~hudson-openstack/nova/trunk
Status: | Merged |
---|---|
Approved by: | Josh Kearney on 2011-03-24 |
Approved revision: | 854 |
Merged at revision: | 867 |
Proposed branch: | lp:~justin-fathomdb/nova/libvirt-getversion-whackamole |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
23 lines (+12/-1) 1 file modified
nova/virt/libvirt_conn.py (+12/-1) |
To merge this branch: | bzr merge lp:~justin-fathomdb/nova/libvirt-getversion-whackamole |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jesse Andrews (community) | Approve on 2011-03-24 | ||
Josh Kearney (community) | Approve on 2011-03-24 | ||
Jay Pipes (community) | 2011-03-23 | Approve on 2011-03-23 | |
Vish Ishaya | 2011-03-23 | Pending | |
Soren Hansen | 2011-03-23 | Pending | |
Review via email:
|
Commit message
Detect if user is running the default Lucid version of libvirt, and give a nicer error message
Description of the change
Check both libvirt connection object (Maverick) and libvirt namespace (Lucid) for getVersion function
Earlier versions of the python libvirt binding had getVersion in the libvirt namespace, not on the connection object. Check both.
justinsb (justin-fathomdb) wrote : | # |
Though this patch let me get further, I think hit this error when launching an image " virConnect instance has no attribute 'nwfilterDefine
Paging Soren...
Soren: Is it a lost cause trying to support Lucid's libvirt? If so, there's no point merging this patch (but I could change it to give a friendly error message if an old libvirt is installed!)
Vish Ishaya (vishvananda) wrote : | # |
I think it is a lost cause. That is why we have a backported libvirt in the ppa.
Vish
On Mar 23, 2011, at 10:01 AM, justinsb wrote:
> Though this patch let me get further, I think hit this error when launching an image " virConnect instance has no attribute 'nwfilterDefine
>
> Paging Soren...
>
> Soren: Is it a lost cause trying to support Lucid's libvirt? If so, there's no point merging this patch (but I could change it to give a friendly error message if an old libvirt is installed!)
> --
> https:/
> You are subscribed to branch lp:nova.
justinsb (justin-fathomdb) wrote : | # |
OK... changed this so that it gives a nicer error message if getVersion isn't available on the connection object, along with a note on where to find it in case anyone needs it in future...
Soren Hansen (soren) wrote : | # |
> I think it is a lost cause.
+1
Josh Kearney (jk0) wrote : | # |
Looks good to me. I don't see any harm in making an error message more friendly.
Jesse Andrews (anotherjesse) wrote : | # |
Not sure if it is a lost cause - since it makes it easier to run on other platforms that we don't have a PPA for.
lgtm.