Merge lp:~gmdduf/linaro-image-tools/gauss-support into lp:linaro-image-tools/11.11

Proposed by Bernard Park
Status: Needs review
Proposed branch: lp:~gmdduf/linaro-image-tools/gauss-support
Merge into: lp:linaro-image-tools/11.11
Diff against target: 45 lines (+16/-1)
2 files modified
linaro_image_tools/media_create/boards.py (+16/-0)
linaro_image_tools/media_create/tests/test_media_create.py (+0/-1)
To merge this branch: bzr merge lp:~gmdduf/linaro-image-tools/gauss-support
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Needs Fixing
Review via email: mp+164610@code.launchpad.net

Description of the change

this patch support Samsung Gauss server platform

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

thanks for working on this.
There are a couple of errors that would need fixing:

./linaro_image_tools/media_create/boards.py:1692:1: E302 expected 2 blank lines, found 1
./linaro_image_tools/media_create/boards.py:1702:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/boards.py:1705:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/tests/test_media_create.py:1558:1: E302 expected 2 blank lines, found 1

Those were found running the tests locally.
Also, is it possible for you to add some simple test for the new board? You can take a look at linaro_image_tools/media_create/tests/test_media_create.py, and look for a board like HighBank. The tests basically can be pretty much the same.

Thanks.

review: Needs Fixing
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

we are going to release Linaro Image Tools this week, would you like this to land with the 13.05 release? I can easily fix those errors in case.

Unmerged revisions

623. By Bernard Park

gauss support fix

622. By Bernard Park

gauss support

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py 2013-04-04 08:12:38 +0000
+++ linaro_image_tools/media_create/boards.py 2013-05-19 07:47:27 +0000
@@ -1689,6 +1689,21 @@
1689 bl0_file = os.path.join(chroot_dir, self.bl0_file)1689 bl0_file = os.path.join(chroot_dir, self.bl0_file)
1690 return bl0_file1690 return bl0_file
16911691
1692class GaussConfig(BoardConfig):
1693 def __init__(self):
1694 super(GaussConfig, self).__init__()
1695 self.boot_script = 'boot.scr'
1696 self.bootloader_flavor = 'gauss'
1697 self.kernel_flavors = ['gauss']
1698 self.serial_tty = 'ttySAC0'
1699 self.fatload_command = 'ext2load'
1700 self.load_interface = 'sata'
1701 self.bootfs_type = 'ext2'
1702 self.dtb_addr = '0x81f00000'
1703 self.initrd_addr = '0x82000000'
1704 self.kernel_addr = '0x80007000'
1705 self.load_addr = '0x80008000'
1706
16921707
1693class HighBankConfig(BoardConfig):1708class HighBankConfig(BoardConfig):
1694 def __init__(self):1709 def __init__(self):
@@ -1777,6 +1792,7 @@
1777 'efikamx': EfikamxConfig,1792 'efikamx': EfikamxConfig,
1778 'efikasb': EfikasbConfig,1793 'efikasb': EfikasbConfig,
1779 'fastmodel': FastModelConfig,1794 'fastmodel': FastModelConfig,
1795 'gauss': GaussConfig,
1780 'highbank': HighBankConfig,1796 'highbank': HighBankConfig,
1781 'i386': I386Config,1797 'i386': I386Config,
1782 'igep': IgepConfig,1798 'igep': IgepConfig,
17831799
=== modified file 'linaro_image_tools/media_create/tests/test_media_create.py'
--- linaro_image_tools/media_create/tests/test_media_create.py 2013-04-04 08:12:38 +0000
+++ linaro_image_tools/media_create/tests/test_media_create.py 2013-05-19 07:47:27 +0000
@@ -1555,7 +1555,6 @@
1555 expected = []1555 expected = []
1556 self.assertEqual(expected, self.funcs_calls)1556 self.assertEqual(expected, self.funcs_calls)
15571557
1558
1559class TestPopulateRawPartitionAndroid(TestCaseWithFixtures):1558class TestPopulateRawPartitionAndroid(TestCaseWithFixtures):
15601559
1561 def setUp(self):1560 def setUp(self):

Subscribers

People subscribed via source and target branches