Merge lp:~gmdduf/linaro-image-tools/gauss-support into lp:linaro-image-tools/11.11
Proposed by
Bernard Park
Status: | Needs review |
---|---|
Proposed branch: | lp:~gmdduf/linaro-image-tools/gauss-support |
Merge into: | lp:linaro-image-tools/11.11 |
Diff against target: |
45 lines (+16/-1) 2 files modified
linaro_image_tools/media_create/boards.py (+16/-0) linaro_image_tools/media_create/tests/test_media_create.py (+0/-1) |
To merge this branch: | bzr merge lp:~gmdduf/linaro-image-tools/gauss-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Milo Casagrande (community) | Needs Fixing | ||
Review via email: mp+164610@code.launchpad.net |
Description of the change
this patch support Samsung Gauss server platform
To post a comment you must log in.
Unmerged revisions
- 623. By Bernard Park
-
gauss support fix
- 622. By Bernard Park
-
gauss support
Hi,
thanks for working on this.
There are a couple of errors that would need fixing:
./linaro_ image_tools/ media_create/ boards. py:1692: 1: E302 expected 2 blank lines, found 1 image_tools/ media_create/ boards. py:1702: 26: E222 multiple spaces after operator image_tools/ media_create/ boards. py:1705: 26: E222 multiple spaces after operator image_tools/ media_create/ tests/test_ media_create. py:1558: 1: E302 expected 2 blank lines, found 1
./linaro_
./linaro_
./linaro_
Those were found running the tests locally. image_tools/ media_create/ tests/test_ media_create. py, and look for a board like HighBank. The tests basically can be pretty much the same.
Also, is it possible for you to add some simple test for the new board? You can take a look at linaro_
Thanks.