Code review comment for lp:~gmdduf/linaro-image-tools/gauss-support

Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

thanks for working on this.
There are a couple of errors that would need fixing:

./linaro_image_tools/media_create/boards.py:1692:1: E302 expected 2 blank lines, found 1
./linaro_image_tools/media_create/boards.py:1702:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/boards.py:1705:26: E222 multiple spaces after operator
./linaro_image_tools/media_create/tests/test_media_create.py:1558:1: E302 expected 2 blank lines, found 1

Those were found running the tests locally.
Also, is it possible for you to add some simple test for the new board? You can take a look at linaro_image_tools/media_create/tests/test_media_create.py, and look for a board like HighBank. The tests basically can be pretty much the same.

Thanks.

review: Needs Fixing

« Back to merge proposal