Merge ~freddierice/curtin:mdadm-metadata into curtin:master

[Freddie Rice]

block_meta: pass the metadata parameter into the mdadm_create function

Changing 'metadata' in raid right now is a nop because it is never passed into the mdadm_create function. This change aims to allow the metadata parameter to be passed into the mdadm call.

[Dimitri John Ledkov (xnox)]

which metadata formats, apart from default, do you intend to use here? Do we need more tests for extra metadata formats?

[Ryan Harper (raharper)]

This looks fine to me. I think we have sufficient testing around raid; AFAIK, we don't do anything that requires 1.2. I don't think we need to add any additional testing unless we know of a scenario where a specific metadata level is known to not work.

We don't have any tests on DDF or imsm (though this requires specific hardware that's not virtualizable IIUC). If this exposes a bug for a specific format; that would be good to know and we can fix/add testing then.

Unmerged commits

c08d2b7... by Freddie Rice on 2020-09-24

block_meta: add metadata parameter to ci tests

3ca8137... by Freddie Rice <email address hidden> on 2020-09-24

block_meta: add metadata to raid

diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
index dee73b1..424f3d3 100644
--- a/curtin/commands/block_meta.py
+++ b/curtin/commands/block_meta.py
@@ -1518,7 +1518,8 @@ def raid_handler(info, storage_config):
     if create_raid:
         mdadm.mdadm_create(md_devname, raidlevel,
                            device_paths, spare_device_paths,
-                           info.get('mdname', ''))
+                           info.get('mdname', ''),
+                           metadata=info.get('metadata'))
 
     wipe_mode = info.get('wipe')
     if wipe_mode:
diff --git a/tests/unittests/test_commands_block_meta.py b/tests/unittests/test_commands_block_meta.py
index d954296..c9a340b 100644
--- a/tests/unittests/test_commands_block_meta.py
+++ b/tests/unittests/test_commands_block_meta.py
@@ -1892,7 +1892,7 @@ class TestRaidHandler(CiTestCase):
         self.m_getpath.side_effect = iter(devices)
         block_meta.raid_handler(self.storage_config['mddevice'],
                                 self.storage_config)
-        self.assertEqual([call(md_devname, 5, devices, [], '')],
+        self.assertEqual([call(md_devname, 5, devices, [], '', metadata=None)],
                          self.m_mdadm.mdadm_create.call_args_list)
 
     @patch('curtin.commands.block_meta.raid_verify')