Merge lp:~ewanmellor/swift/lp820185 into lp:~hudson-openstack/swift/trunk

[Ewan Mellor]

Bug #820185: Intermittent TypeError NoneType in atexit handler of unit tests

Work around what appears to be a Python standard library bug by silencing
exceptions in the logging library.

Bug #820185: Intermittent TypeError NoneType in atexit handler of unit tests

Work around what appears to be a Python standard library bug by silencing
exceptions in the logging library.

[gholt (gholt)]

I've seen this for quite some time in the builds as well, though not on my local machine as of yet. That particular stack trace doesn't seem to cause any failures outside of what it displays. Is this required to be fixed?

I'm worried the side-effect of not raising any exceptions with logging could cause us more and real problems (handlers not set correctly, bugs in formatters, etc.) As a quick example, this logging problem is completely silent and no one would realize a .critical() was even attempted.

    import logging

    logging.raiseExceptions = False
    logger = logging.getLogger()
    logger.addHandler(logging.StreamHandler())
    logger.critical('test %s %s', ('one',))

[gholt (gholt)]

Oh, nevermind. Didn't realize it was a test only thing, lol.

review: Approve

[John Dickinson (notmyname)]

lgtm

review: Approve

=== modified file 'test/__init__.py'
--- test/__init__.py	2011-02-24 22:21:14 +0000
+++ test/__init__.py	2011-08-03 06:06:11 +0000
@@ -12,6 +12,12 @@
 setattr(__builtin__, '_', lambda x: x)
 
 
+# Work around what seems to be a Python bug.
+# c.f. https://bugs.launchpad.net/swift/+bug/820185.
+import logging
+logging.raiseExceptions = False
+
+
 def get_config():
     """
     Attempt to get a functional config dictionary.