Code review comment for lp:~ewanmellor/swift/lp820185

I've seen this for quite some time in the builds as well, though not on my local machine as of yet. That particular stack trace doesn't seem to cause any failures outside of what it displays. Is this required to be fixed?

I'm worried the side-effect of not raising any exceptions with logging could cause us more and real problems (handlers not set correctly, bugs in formatters, etc.) As a quick example, this logging problem is completely silent and no one would realize a .critical() was even attempted.

    import logging

    logging.raiseExceptions = False
    logger = logging.getLogger()
    logger.addHandler(logging.StreamHandler())
    logger.critical('test %s %s', ('one',))