Merge lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option into lp:lava-master-image-scripts

Proposed by Dave Pigott
Status: Needs review
Proposed branch: lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option
Merge into: lp:lava-master-image-scripts
Diff against target: 64 lines (+14/-4)
2 files modified
README (+3/-0)
lava-create-master (+11/-4)
To merge this branch: bzr merge lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option
Reviewer Review Type Date Requested Status
Linaro Validation Team Pending
Review via email: mp+156576@code.launchpad.net

Description of the change

Added an option to specify master rootfs size. Additionally added alternative options for testrootfs size to maintain (a) backwards compatibility and (b) consistency in option naming

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+ echo "Usage: lava-create-master [--rebuild-vanilla] [--verbose] (--help | --version | DEVICE) [ --output|-o IMAGE] [ --master-rootfs-size|-m SIZE] [--test-rootfs-size|-r|rootfs-size SIZE] [--userdata-size|-u SIZE]"

You probably wanted --rootfs-size there for consistency, also, moving -r to be the last item of the alternative set would be consistent with the rest

Revision history for this message
Dave Pigott (dpigott) wrote :

Yeah, I maintained rootfs-size for backward compatibility. Good point about placement. Will make that change.

On 2 Apr 2013, at 15:50, Zygmunt Krynicki <email address hidden> wrote:

> + echo "Usage: lava-create-master [--rebuild-vanilla] [--verbose] (--help | --version | DEVICE) [ --output|-o IMAGE] [ --master-rootfs-size|-m SIZE] [--test-rootfs-size|-r|rootfs-size SIZE] [--userdata-size|-u SIZE]"
>
> You probably wanted --rootfs-size there for consistency, also, moving -r to be the last item of the alternative set would be consistent with the rest
> --
> https://code.launchpad.net/~dpigott/lava-master-image-scripts/add-master-rootfs-size-option/+merge/156576
> You are the owner of lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option.

75. By Dave Pigott

Consistency change in help order

Unmerged revisions

75. By Dave Pigott

Consistency change in help order

74. By Dave Pigott

Add ability to specify master image rootfs size

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches