Code review comment for lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option

Dave Pigott (dpigott) wrote :

Yeah, I maintained rootfs-size for backward compatibility. Good point about placement. Will make that change.

On 2 Apr 2013, at 15:50, Zygmunt Krynicki <email address hidden> wrote:

> + echo "Usage: lava-create-master [--rebuild-vanilla] [--verbose] (--help | --version | DEVICE) [ --output|-o IMAGE] [ --master-rootfs-size|-m SIZE] [--test-rootfs-size|-r|rootfs-size SIZE] [--userdata-size|-u SIZE]"
>
> You probably wanted --rootfs-size there for consistency, also, moving -r to be the last item of the alternative set would be consistent with the rest
> --
> https://code.launchpad.net/~dpigott/lava-master-image-scripts/add-master-rootfs-size-option/+merge/156576
> You are the owner of lp:~dpigott/lava-master-image-scripts/add-master-rootfs-size-option.

« Back to merge proposal