Merge lp:~diegosarmentero/ubuntuone-windows-installer/847796 into lp:ubuntuone-windows-installer

[Diego Sarmentero]

Fixed: Setup account button can be clicked with no data

Fixed: Setup account button can be clicked with no data

[Natalia Bidart (nataliabidart)]

The code looks good.

While testing it IRL, I got this trace:

2011-09-13 11:54:32,773:773.999929428 - ubuntu_sso.controllers - DEBUG - SetUpAc
countController.is_correct_password_confirmation
Traceback (most recent call last):
  File "E:\ussoc\trunk\ubuntu_sso\qt\controllers.py", line 358, in _enable_setup
_button
    self.view.wizard().button(self.set_up_account).setEnabled(enabled)
TypeError: QWidget.setEnabled(bool): argument 1 has unexpected type 'unicode'

Shall we fix that in this branch?

review: Needs Information

[Diego Sarmentero (diegosarmentero)]

> The code looks good.
>
> While testing it IRL, I got this trace:
>
> 2011-09-13 11:54:32,773:773.999929428 - ubuntu_sso.controllers - DEBUG -
> SetUpAc
> countController.is_correct_password_confirmation
> Traceback (most recent call last):
> File "E:\ussoc\trunk\ubuntu_sso\qt\controllers.py", line 358, in
> _enable_setup
> _button
> self.view.wizard().button(self.set_up_account).setEnabled(enabled)
> TypeError: QWidget.setEnabled(bool): argument 1 has unexpected type 'unicode'
>
> Shall we fix that in this branch?

This bug is from SSO and it is fixed in another branch

[Natalia Bidart (nataliabidart)]

Approving then!

review: Approve

[Roberto Alsina (ralsina)]

+1 allowing for the mentioned above

review: Approve

=== modified file 'ubuntuone_installer/gui/qt/setup_account.py'
--- ubuntuone_installer/gui/qt/setup_account.py	2011-09-12 19:34:20 +0000
+++ ubuntuone_installer/gui/qt/setup_account.py	2011-09-13 11:24:24 +0000
@@ -101,6 +101,7 @@
         self.setButtonText(QtGui.QWizard.CustomButton3, _('Set Up Account'))
         self.set_up_button = self.wizard().button(QtGui.QWizard.CustomButton3)
         self.set_up_button.clicked.connect(self.wizard().overlay.show)
+        self.set_up_button.setEnabled(False)
 
         self.ui.name_label.setText(NAME)
         self.ui.email_label.setText(EMAIL)
 
=== modified file 'ubuntuone_installer/gui/qt/tests/test_gui.py'
--- ubuntuone_installer/gui/qt/tests/test_gui.py	2011-09-12 18:49:40 +0000
+++ ubuntuone_installer/gui/qt/tests/test_gui.py	2011-09-13 11:24:24 +0000
@@ -168,6 +168,7 @@
         self.ui.restart()
         self.ui.show()
         self.addCleanup(self.ui.hide)
+        self.assertFalse(setup_page.set_up_button.isEnabled())
         self.assertFalse(setup_page.ui.name_assistance.isVisible())
         self.assertFalse(setup_page.ui.email_assistance.isVisible())
         self.assertFalse(setup_page.ui.confirm_email_assistance.isVisible())