Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/847796

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The code looks good.

While testing it IRL, I got this trace:

2011-09-13 11:54:32,773:773.999929428 - ubuntu_sso.controllers - DEBUG - SetUpAc
countController.is_correct_password_confirmation
Traceback (most recent call last):
  File "E:\ussoc\trunk\ubuntu_sso\qt\controllers.py", line 358, in _enable_setup
_button
    self.view.wizard().button(self.set_up_account).setEnabled(enabled)
TypeError: QWidget.setEnabled(bool): argument 1 has unexpected type 'unicode'

Shall we fix that in this branch?

review: Needs Information

« Back to merge proposal