Merge lp:~compiz-team/compiz/compiz.fix_1159430 into lp:compiz/0.9.10
Status: | Superseded |
---|---|
Proposed branch: | lp:~compiz-team/compiz/compiz.fix_1159430 |
Merge into: | lp:compiz/0.9.10 |
Diff against target: |
398 lines (+173/-25) 11 files modified
debian/changelog (+2/-1) include/core/abiversion.h (+1/-1) include/core/screen.h (+11/-3) plugins/opengl/src/paint.cpp (+6/-1) plugins/wallpaper/src/wallpaper.cpp (+29/-2) plugins/wallpaper/src/wallpaper.h (+4/-0) src/event.cpp (+7/-2) src/privatescreen.h (+6/-3) src/privatescreen/tests/test-privatescreen.cpp (+67/-2) src/screen.cpp (+20/-7) src/window.cpp (+20/-3) |
To merge this branch: | bzr merge lp:~compiz-team/compiz/compiz.fix_1159430 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
MC Return | Pending | ||
Daniel van Vugt | Pending | ||
PS Jenkins bot | continuous-integration | Pending | |
Sebastien Bacher | Pending | ||
Review via email: mp+176799@code.launchpad.net |
This proposal supersedes a proposal from 2013-06-21.
Description of the change
Handle ARGB desktop windows correctly.
core: compiz:
increment or decrement desktop windows based on their visual type.
desktopWindowCount () now returns the number of RGB and ARGB desktop windows,
argbDesktopWind
If they are equal, the only desktop window is ARGB.
opengl: Draw the root window background if the desktop window is ARGB.
wallpaper: Lie to core and say that our fake desktop window is RGB so that
core does not draw the root window background. Paint the desktop wallpaper
beneath the desktop window so that the ARGB desktop window is visible on
top of it.
Tests added for the increment/decrement logic in DesktopWindowCount.
Unmerged revisions
- 3744. By Sam Spilsbury
-
Added more missing changes
- 3743. By Sam Spilsbury
-
Add missing change
- 3742. By Sam Spilsbury
-
Handle ARGB desktop windows correctly.
core: compiz:
:private_ screen: :DesktopWindowC ount - provide methods to
increment or decrement desktop windows based on their visual type.desktopWindowCount () now returns the number of RGB and ARGB desktop windows,
argbDesktopWindowCount () just returns the number of ARGB desktop windows. If they are equal, the only desktop window is ARGB.
opengl: Draw the root window background if the desktop window is ARGB.
wallpaper: Lie to core and say that our fake desktop window is RGB so that
core does not draw the root window background. Paint the desktop wallpaper
beneath the desktop window so that the ARGB desktop window is visible on
top of it.
FAILED: Continuous integration, rev:3742 jenkins. qa.ubuntu. com/job/ compiz- ci/205/ jenkins. qa.ubuntu. com/job/ compiz- gles-ci/ ./build= pbuilder, distribution= raring, flavor= amd64/246/ console jenkins. qa.ubuntu. com/job/ compiz- saucy-amd64- ci/18/console jenkins. qa.ubuntu. com/job/ compiz- saucy-armhf- ci/18/console jenkins. qa.ubuntu. com/job/ compiz- saucy-i386- ci/18/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ compiz- ci/205/ rebuild
http://