Merge lp:~compiz-team/compiz/compiz.fix_1039843 into lp:compiz/0.9.8

Proposed by Sam Spilsbury
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3317
Merged at revision: 3318
Proposed branch: lp:~compiz-team/compiz/compiz.fix_1039843
Merge into: lp:compiz/0.9.8
Diff against target: 46 lines (+19/-1)
3 files modified
plugins/imgsvg/CMakeLists.txt (+12/-1)
plugins/imgsvg/src/imgsvg-config.h.in (+1/-0)
plugins/imgsvg/src/imgsvg.h (+6/-0)
To merge this branch: bzr merge lp:~compiz-team/compiz/compiz.fix_1039843
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Daniel van Vugt Needs Fixing
Review via email: mp+120689@code.launchpad.net

Commit message

Detect if rsvg 2.36.2 is installed (LP: #1039843)

Description of the change

Detect if rsvg 2.36.2 is installed

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Tested OK

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-compiz-core/60/console reported an error when processing this lp:~compiz-team/compiz/compiz.fix_1039843 branch.
Not merging it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Jenkins says:
/usr/include/librsvg-2.0/librsvg/rsvg-cairo.h:27:2: error: #warning "Including <librsvg/rsvg-cairo.h> directly is deprecated." [-Werror=cpp]
cc1plus: all warnings being treated as errors

review: Needs Fixing
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/imgsvg/CMakeLists.txt'
--- plugins/imgsvg/CMakeLists.txt 2009-03-15 05:09:18 +0000
+++ plugins/imgsvg/CMakeLists.txt 2012-08-22 05:09:19 +0000
@@ -2,4 +2,15 @@
22
3include (CompizPlugin)3include (CompizPlugin)
44
5compiz_plugin(imgsvg PLUGINDEPS composite opengl PKGDEPS cairo>=1.0 cairo-xlib librsvg-2.0>=2.14.0)
6\ No newline at end of file5\ No newline at end of file
6pkg_check_modules (RSVG librsvg-2.0>=2.36.2)
7
8if (RSVG_FOUND)
9 compiz_set (HAVE_RSVG_2_36_2 1)
10endif (RSVG_FOUND)
11
12configure_file (${CMAKE_CURRENT_SOURCE_DIR}/src/imgsvg-config.h.in
13 ${CMAKE_CURRENT_BINARY_DIR}/src/imgsvg-config.h)
14
15include_directories (${CMAKE_CURRENT_BINARY_DIR}/src)
16
17compiz_plugin(imgsvg PLUGINDEPS composite opengl PKGDEPS cairo>=1.0 cairo-xlib librsvg-2.0>=2.14.0)
718
=== added file 'plugins/imgsvg/src/imgsvg-config.h.in'
--- plugins/imgsvg/src/imgsvg-config.h.in 1970-01-01 00:00:00 +0000
+++ plugins/imgsvg/src/imgsvg-config.h.in 2012-08-22 05:09:19 +0000
@@ -0,0 +1,1 @@
1#cmakedefine HAVE_RSVG_2_36_2
02
=== modified file 'plugins/imgsvg/src/imgsvg.h'
--- plugins/imgsvg/src/imgsvg.h 2012-08-21 11:33:35 +0000
+++ plugins/imgsvg/src/imgsvg.h 2012-08-22 05:09:19 +0000
@@ -33,8 +33,14 @@
33#include <stdlib.h>33#include <stdlib.h>
34#include <string.h>34#include <string.h>
3535
36#include <imgsvg-config.h>
37
36#include <cairo/cairo-xlib.h>38#include <cairo/cairo-xlib.h>
37#include <librsvg/rsvg.h>39#include <librsvg/rsvg.h>
40
41#ifndef HAVE_RSVG_2_36_2
42#include <librsvg/rsvg-cairo.h>
43#endif
3844
39#include <X11/Xatom.h>45#include <X11/Xatom.h>
40#include <X11/extensions/shape.h>46#include <X11/extensions/shape.h>

Subscribers

People subscribed via source and target branches