Merge lp:~cjwatson/launchpad-buildd/twisted-17.1.0-compat into lp:launchpad-buildd

Proposed by Colin Watson
Status: Merged
Merged at revision: 329
Proposed branch: lp:~cjwatson/launchpad-buildd/twisted-17.1.0-compat
Merge into: lp:launchpad-buildd
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
lpbuildd/buildd-slave.tac (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad-buildd/twisted-17.1.0-compat
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Launchpad code reviewers Pending
Review via email: mp+340019@code.launchpad.net

Commit message

Make buildd-slave.tac compatible with Twisted >= 17.1.0, which drops support for passing an unqualified port to strports.service.

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2018-01-15 10:08:55 +0000
+++ debian/changelog 2018-02-27 13:48:11 +0000
@@ -1,3 +1,10 @@
1launchpad-buildd (159) UNRELEASED; urgency=medium
2
3 * Make buildd-slave.tac compatible with Twisted >= 17.1.0, which drops
4 support for passing an unqualified port to strports.service.
5
6 -- Colin Watson <cjwatson@ubuntu.com> Tue, 27 Feb 2018 13:22:20 +0000
7
1launchpad-buildd (158) xenial; urgency=medium8launchpad-buildd (158) xenial; urgency=medium
29
3 [ Steve Langasek ]10 [ Steve Langasek ]
411
=== modified file 'lpbuildd/buildd-slave.tac'
--- lpbuildd/buildd-slave.tac 2017-11-22 15:25:33 +0000
+++ lpbuildd/buildd-slave.tac 2018-02-27 13:48:11 +0000
@@ -57,7 +57,7 @@
57root.putChild('filecache', static.File(conf.get('slave', 'filecache')))57root.putChild('filecache', static.File(conf.get('slave', 'filecache')))
58slavesite = server.Site(root)58slavesite = server.Site(root)
5959
60strports.service(slave.slave._config.get("slave", "bindport"),60strports.service("tcp:%s" % slave.slave._config.get("slave", "bindport"),
61 slavesite).setServiceParent(builddslaveService)61 slavesite).setServiceParent(builddslaveService)
6262
63# You can interact with a running slave like this:63# You can interact with a running slave like this:

Subscribers

People subscribed via source and target branches

to all changes: