Merge lp:~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership into lp:~sale-core-editors/sale-wkfl/7.0
Proposed by
Nicolas Bessi - Camptocamp
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 36 |
Merged at revision: | 29 |
Proposed branch: | lp:~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership |
Merge into: | lp:~sale-core-editors/sale-wkfl/7.0 |
Diff against target: |
290 lines (+251/-0) 7 files modified
sale_sourced_by_line/__init__.py (+22/-0) sale_sourced_by_line/__openerp__.py (+48/-0) sale_sourced_by_line/model/__init__.py (+22/-0) sale_sourced_by_line/model/sale.py (+54/-0) sale_sourced_by_line/test/sale_order_not_sourced.yml (+38/-0) sale_sourced_by_line/test/sale_order_source.yml (+40/-0) sale_sourced_by_line/view/sale_view.xml (+27/-0) |
To merge this branch: | bzr merge lp:~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
Raphaël Valyi - http://www.akretion.com | Approve | ||
Romain Deheele - Camptocamp (community) | code review, test | Approve | |
Joël Grand-Guillaume @ camptocamp | code review + test | Needs Fixing | |
Review via email: mp+194527@code.launchpad.net |
Description of the change
Add sale_sourced_
To post a comment you must log in.
Hi Nicolas,
Thanks for extracting those modules ! I think it would be better to split this MP in two :
* One fore sale_sourced_ by_line and sale_ownership in this project
* One for stock_location_ ownership in this project I suggest: https:/ /launchpad. net/stock- logistic- warehouse
I know dependencies are together here, but I'm in favor of giving the priority to modules purpose rather than publishing them by dependencies..
Regards,
Joël