Merge lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

[Nicolas Bessi - Camptocamp]

[ADD] stock_location_ownership.

See https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership/+merge/194527 for more details

[Romain Deheele - Camptocamp (romaindeheele)]

Guewen,

Changes about sale and sale order line (_prepare methods on sale order, field location_id on sale order line, sale views and sale tests)
are already in sale_sourced_by_line addon proposed here :
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership/+merge/194527

It seems to me that the best location is sale_sourced_by_line because pointed changes concern sale objects.

What do you think about it?

Regards,

Romain

review: Needs Information (code review)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Guewen,
>
> Changes about sale and sale order line (_prepare methods on sale order, field
> location_id on sale order line, sale views and sale tests)
> are already in sale_sourced_by_line addon proposed here :
> https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-
> sale_sourced_and_stock_ownership/+merge/194527
>
> It seems to me that the best location is sale_sourced_by_line because pointed
> changes concern sale objects.
>
> What do you think about it?
>
> Regards,
>
> Romain

Hello Romain,

Despite my name on the revision, I'm not the author of the rev. 37. I don't understand exactly how does work this extraction script regarding the authorship... Well, though I'm the author of the original module, and the thing you point is correct: the sale.py module is not supposed to exist (not imported BTW), it has been removed in the original module. I guess this is a extraction error.

[lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi]

40. By Guewen Baconnier @ Camptocamp on 2013-12-11

[FIX] remove python modules and views related to sale, added by error during extraction

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I removed the superfluous files.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

@Romain, can you recheck please?

[Romain Deheele - Camptocamp (romaindeheele)]

Thanks Guewen,

It's ok.

Romain

review: Approve (code review and test)

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

The link you refer to in your description is broken.

review: Needs Information

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Will you please ask for review from the stock core team again?
I didn't intend to claim the review in their name. I didn't remember I was part of the team, sorry.
I'm leaving the team for now as I'm only just discovering the branches.

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Would you be so kind as to explain the use case for this ?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Would you be so kind as to explain the use case for this ?

It is for companies (seems to happen more often in NGO) that have one or several locations in a warehouse where the goods are not theirs, but are the goods of a supplier. Hence the ownership on the location.

Then, the workflow may vary but an example is that a sales order with a location having a different ownership could generate a dropship purchase order to the owner or generate an invoice.

This is used in https://code.launchpad.net/openerp-humanitarian-ngo

[Pedro Manuel Baeza (pedro.baeza)]

Reading your explanation, I wonder if you can't use already present functionality of partner locations, that allows to link an address (and thus, a partner or ownership).

Regards.

[Pedro Manuel Baeza (pedro.baeza)]

I think this one has been merged too fast, with only one approval, and two information requested.

For the moment, I see that there's no pot file.

Could you please ellaborate why this merge?

Regards.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Well it kinda have the whole c2c approval, developped by Guewen proposed by Nicolas, approved by Romain, commited by Alexandre and authored Joël (ok perhaps there it bugged a little here ^^)

If we do an other MP for the pot file will it be ok for you ?

By the way I give my approval for this one that way

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

My information request was about the convenience of the module, but anyways, it's only an opinion. Please put an MP with the pot file, or better.

Regards.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Pedro, I agree that it would have been better if the question was answered before the merge.
Now, I'm sure there was an excellent reason why the existing field couldn't be used, even if I can't remember what it is; Joël thought about this module and I remember asking him the exact same question, so there was a reason. Joël if you can answer...

I suggest that we propose a merge with the .pot and maybe improve the description of the module so it shows what it brings compared to the existing field.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

The proper refered MP was in Romain's comment https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership/+merge/194527

Wrong team was set I fixed the link

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen, thank you very much for the explanation. Improved description will certainly help others like me to understand the purpose of the module.

Regards.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

my most sincere apologies to Pedro and the rest of the community.

I could see no objection myself, the MP was old and I felt the information had been provided, but I may have been to quick indeed. My intent was not to hijack the process.

=== added directory 'stock_location_ownership'
=== added file 'stock_location_ownership/__init__.py'
--- stock_location_ownership/__init__.py	1970-01-01 00:00:00 +0000
+++ stock_location_ownership/__init__.py	2013-12-11 20:02:32 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import model

=== added file 'stock_location_ownership/__openerp__.py'
--- stock_location_ownership/__openerp__.py	1970-01-01 00:00:00 +0000
+++ stock_location_ownership/__openerp__.py	2013-12-11 20:02:32 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{'name': 'Stock Location Ownership',
+ 'version': '0.1',
+ 'author': 'Camptocamp',
+ 'category': 'Warehouse',
+ 'license': 'AGPL-3',
+ 'complexity': 'normal',
+ 'images': [],
+ 'website': "http://www.camptocamp.com",
+ 'description': """
+Stock Location Ownership
+========================
+
+Adds an ownership on the stock locations
+""",
+ 'depends': ['stock',
+             ],
+ 'demo': [],
+ 'data': ['view/stock_view.xml',
+          ],
+ 'test': [],
+ 'auto_install': False,
+ 'installable': True,
+ }

=== added directory 'stock_location_ownership/i18n'
=== added directory 'stock_location_ownership/model'
=== added file 'stock_location_ownership/model/__init__.py'
--- stock_location_ownership/model/__init__.py	1970-01-01 00:00:00 +0000
+++ stock_location_ownership/model/__init__.py	2013-12-11 20:02:32 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import stock

=== added file 'stock_location_ownership/model/stock.py'
--- stock_location_ownership/model/stock.py	1970-01-01 00:00:00 +0000
+++ stock_location_ownership/model/stock.py	2013-12-11 20:02:32 +0000
@@ -0,0 +1,34 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+
+
+class stock_location(orm.Model):
+    _inherit = 'stock.location'
+
+    _columns = {
+        'owner_id': fields.many2one(
+            'res.partner',
+            'Owner',
+            help="Owner of the location if different from the company "
+                 "or address."),
+    }

=== added directory 'stock_location_ownership/test'
=== added directory 'stock_location_ownership/view'
=== added file 'stock_location_ownership/view/stock_view.xml'
--- stock_location_ownership/view/stock_view.xml	1970-01-01 00:00:00 +0000
+++ stock_location_ownership/view/stock_view.xml	2013-12-11 20:02:32 +0000
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data noupdate="0">
+        <record id="view_stock_location_form" model="ir.ui.view">
+            <field name="name">stock.location.form</field>
+            <field name="model">stock.location</field>
+            <field name="inherit_id" ref="stock.view_location_form"/>
+            <field name="arch" type="xml">
+                <field name="partner_id" position="after">
+                    <field name="owner_id"/>
+                </field>
+            </field>
+        </record>
+    </data>
+</openerp>