Merge ~callmepk/ubuntu-release-upgrader:ubuntu/focal into ubuntu-release-upgrader:ubuntu/focal

Proposed by Patrick Wu
Status: Needs review
Proposed branch: ~callmepk/ubuntu-release-upgrader:ubuntu/focal
Merge into: ubuntu-release-upgrader:ubuntu/focal
Diff against target: 23 lines (+13/-0)
1 file modified
DistUpgrade/DistUpgradeQuirks.py (+13/-0)
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Review via email: mp+401850@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I've gone ahead and merge Didier's change which addressed the same issue in a better way.

https://code.launchpad.net/~ubuntu-core-dev/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/411011

review: Disapprove

Unmerged commits

ec9aa7d... by Patrick Wu

Fix snap connectivity check failed silently when snapd service not
enabled (LP: #1926267)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/DistUpgrade/DistUpgradeQuirks.py b/DistUpgrade/DistUpgradeQuirks.py
index 28122bb..acd217b 100644
--- a/DistUpgrade/DistUpgradeQuirks.py
+++ b/DistUpgrade/DistUpgradeQuirks.py
@@ -548,6 +548,19 @@ class DistUpgradeQuirks(object):
548 elif 'error: access denied' in connected[1]:548 elif 'error: access denied' in connected[1]:
549 res = False549 res = False
550 logging.error("Not running as root!")550 logging.error("Not running as root!")
551 elif '/run/snapd.socket: connect: no such file or directory' in connected[1]:
552 summary = _("Connection to the snapd service failed")
553 msg = _("Connection to the snapd service failed. "
554 "Please make sure snapd service is enabled "
555 "in the systemd before release upgrade.\n"
556 "For WSL users, due to lack of support for "
557 "systemd, snap will not able to "
558 "work properly. Please remove snapd package "
559 "before the distribution update."
560 )
561 self._view.error(summary, msg)
562 self.controller.abort()
563 )
551 if not res:564 if not res:
552 self.controller.abort()565 self.controller.abort()
553566

Subscribers

People subscribed via source and target branches