Merge lp:~alan-griffiths/mir/bump-protocol-version into lp:mir

[Alan Griffiths]

The protocol version needs to change we dropped message RaiseRequest (and subsumed it into RequestOperation)

[Alan Griffiths (alan-griffiths)]

While this is technically correct, it might be better to retain compatibility with 0.26 clients. For that to happen:

1. the server needs to support RaiseRequest (deprecated)
2. the protocol needs bumping to 4.1

The advantage being that (for example) a 0.27 based server snap could interwork with a 0.26 based client snap. (Of course, if the client snap relied on mir-libs this wouldn't be necessary.)

Opinions?

review: Needs Information

[Gerry Boland (gerboland)]

Changing the protocol version only impacts the Snappy world. We should ask them if a protocol change impacts any project of theirs (I'm not aware of any Mir-based work happening on their side though)

[Alan Griffiths (alan-griffiths)]

On second thoughts, I think we should be able to rely on client snaps following the "use mir-libs" guideline.

[Alan Griffiths (alan-griffiths)]

> On second thoughts, I think we should be able to rely on client snaps
> following the "use mir-libs" guideline.

On third thoughts - we won't be shipping 0.27 on UbuntuCore anyway

[Gerry Boland (gerboland)]

All good so

review: Approve

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:4202
https://mir-jenkins.ubuntu.com/job/mir-ci/3470/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4741
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4899
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/4888
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/4888
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4888
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4778/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4778
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4778/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3470/rebuild

review: Approve (continuous-integration)

=== modified file 'src/include/common/mir/protobuf/protocol_version.h'
--- src/include/common/mir/protobuf/protocol_version.h	2017-05-08 03:04:26 +0000
+++ src/include/common/mir/protobuf/protocol_version.h	2017-06-30 10:57:33 +0000
@@ -27,12 +27,12 @@
 {
 inline constexpr int current_protocol_version()
 { 
-    return MIR_VERSION_NUMBER(0,4,0);
+    return MIR_VERSION_NUMBER(0,5,0);
 }
 
 inline constexpr int oldest_compatible_protocol_version()
 {
-    return MIR_VERSION_NUMBER(0,4,0);
+    return MIR_VERSION_NUMBER(0,5,0);
 }
 
 inline constexpr int next_incompatible_protocol_version()