Mir

Merge lp:~alan-griffiths/mir/bump-protocol-version into lp:mir/0.27

Proposed by Alan Griffiths on 2017-06-29
Status: Superseded
Proposed branch: lp:~alan-griffiths/mir/bump-protocol-version
Merge into: lp:mir/0.27
Diff against target: 18 lines (+2/-2)
1 file modified
src/include/common/mir/protobuf/protocol_version.h (+2/-2)
To merge this branch: bzr merge lp:~alan-griffiths/mir/bump-protocol-version
Reviewer Review Type Date Requested Status
Alan Griffiths Needs Information on 2017-06-30
Review via email: mp+326543@code.launchpad.net

This proposal has been superseded by a proposal from 2017-06-30.

Commit message

The protocol version needs to change we dropped message RaiseRequest (and subsumed it into RequestOperation)

To post a comment you must log in.
Alan Griffiths (alan-griffiths) wrote :

While this is technically correct, it might be better to retain compatibility with 0.26 clients. For that to happen:

1. the server needs to support RaiseRequest (deprecated)
2. the protocol needs bumping to 4.1

The advantage being that (for example) a 0.27 based server snap could interwork with a 0.26 based client snap. (Of course, if the client snap relied on mir-libs this wouldn't be necessary.)

Opinions?

review: Needs Information
Gerry Boland (gerboland) wrote :

Changing the protocol version only impacts the Snappy world. We should ask them if a protocol change impacts any project of theirs (I'm not aware of any Mir-based work happening on their side though)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/include/common/mir/protobuf/protocol_version.h'
2--- src/include/common/mir/protobuf/protocol_version.h 2017-05-08 03:04:26 +0000
3+++ src/include/common/mir/protobuf/protocol_version.h 2017-06-29 16:28:39 +0000
4@@ -27,12 +27,12 @@
5 {
6 inline constexpr int current_protocol_version()
7 {
8- return MIR_VERSION_NUMBER(0,4,0);
9+ return MIR_VERSION_NUMBER(0,5,0);
10 }
11
12 inline constexpr int oldest_compatible_protocol_version()
13 {
14- return MIR_VERSION_NUMBER(0,4,0);
15+ return MIR_VERSION_NUMBER(0,5,0);
16 }
17
18 inline constexpr int next_incompatible_protocol_version()

Subscribers

People subscribed via source and target branches